8000 Resettable feature by pascalwacker · Pull Request #213 · msgphp/msgphp · GitHub
[go: up one dir, main page]
Skip to content

Resettable feature #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Resettable feature #213

wants to merge 3 commits into from

Conversation

pascalwacker
Copy link
Contributor

Since not all db/field length definitions are done in *.orm.xml files (see #211 and #210), a modification of the ObjectFieldMappings class is needed.

I've added a new config value: msgphp.doctrine.key_max_length defaulting to 255 and getting padded to the ObjectFieldMappings::provideObjectFieldMappings() function as parameter. it then is used to set a length limit for unique/key entries.

AFAIK there's no way to reuse this parameter for the *.orm.xml files. We could theoretically modify the CacheWarmer class to check the files it's copying for a string like %msgphp.doctrine.key_max_length% and if that string exists, replace it with the config value in the cache folder. @ro0NL what do you think?

This was referenced Oct 25, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature infrastructure
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pascalwacker @ro0NL
0