8000 modify cacheWarmer to include files from config dir if they exist by pascalwacker · Pull Request #211 · msgphp/msgphp · GitHub
[go: up one dir, main page]
Skip to content

modify cacheWarmer to include files from config dir if they exist #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

modify cacheWarmer to include files from config dir if they exist #211

wants to merge 3 commits into from

Conversation

pascalwacker
Copy link
Contributor

I've modified the CacheWarmer to first check the config folder and only if a file doesn't exist there copy it from the source. This way single files can be overridden, while keeping the default config for others intact.

Possible solution for: #210

Cache Warmer will now check the config dir for the files.

Ex. for the file vendor/msgphp/user/Infra/Doctrine/Resources/dist-mapping/User.Entity.Credential.Email.orm.xml it would first check config/packages/msgphp/user/User.Entity.Credential.Email.orm.xml

Possible future enhancement: Copy the config files when the make command runs.

@pascalwacker pascalwacker mentioned this pull request Oct 24, 2018
Closed
@pascalwacker
Copy link
Contributor Author

@ro0NL I've added a msgphp.doctrine.config_folder parameter in ExtensionHelper.php it defaults to $container->getParameter('kernel.project_dir') . '/config/packages/msgphp/doctrine'

@pascalwacker pascalwacker mentioned this pull request Oct 25, 2018
Closed
@ro0NL ro0NL mentioned this pull request Oct 25, 2018
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature infrastructure
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pascalwacker @ro0NL
0