8000 Windows: don't try to load "mirrored" network plugin by robmry · Pull Request #50155 · moby/moby · GitHub
[go: up one dir, main page]
Skip to content

Windows: don't try to load "mirrored" network plugin #50155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
+52 −3
Merged

Windows: don't try to load "mirrored" network plugin #50155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions daemon/daemon_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,9 +322,11 @@ func (daemon *Daemon) initNetworkController(daemonCfg *config.Config, activeSand
// discover and add HNS networks to windows
// network that exist are removed and added again
for _, v := range hnsresponse {
networkTypeNorm := strings.ToLower(v.Type)
if networkTypeNorm == "private" || networkTypeNorm == "internal" {
continue // workaround for HNS reporting unsupported networks
// Ignore HNS network types that are not supported by the Docker driver. This
// avoids trying to load a plugin named after the network type, which adds a 15s
// startup delay per network of this type on the host.
if !winlibnetwork.IsAdoptableNetworkType(v.Type) {
continue
}
var n *libnetwork.Network
daemon.netController.WalkNetworks(func(current *libnetwork.Network) bool {
Expand Down
47 changes: 47 additions & 0 deletions libnetwork/drivers/windows/windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,53 @@ func IsBuiltinLocalDriver(networkType string) bool {
return ok
}

var unadoptableNetworkTypes = map[string]struct{}{
// "internal" and "private" are included here to preserve the workarounds added
// in commits b91fd26 ("Ignore HNS networks with type Private") and 6a1a4f9 ("Fix
// long startup on windows, with non-hns governed Hyper-V networks").
//
// That long delay was caused by trying to load network driver plugins named
// "internal" and "private". The workaround doesn't seem necessary now, because
// those network types are both associated with the windows [driver] by the
// entries in [builtinLocalDrivers]. (The code has been refactored, but those
// network types were included at the time the workaround was added. Something
// else must have changed in the meantime.)
//
// TODO(robmry) - remove internal/private from this map? ...
//
// On startup the daemon tries to adopt all existing HNS networks by creating
// corresponding Docker networks. (HNS is the source of truth for Windows, not
// Docker's network store.)
//
// So, removing internal/private from this map would have two consequences
// (removing restrictions that were probably introduced unintentionally by the
// workarounds mentioned above):
// - internal/private networks created on the host would appear in Docker's list
// of networks, and it'd be possible to create containers in those networks.
// That would match the behaviour for other network types (including the other
// currently-undocumented type "ics").
// - On startup, if an internal/private network originally created by Docker has
// been reconfigured outside Docker, the network definition in Docker's store
// will be updated to match the current HNS configuration (as it is for other
// network types).
"internal": {},
"private": {},

// "mirrored" is not currently in the list of HNS network types understood by
// Docker [builtinLocalDrivers]. So, it's not possible for Docker to create a
// network of this type. And, if the host has "mirrored" networks, Docker
// should not spend time on startup trying to load a plugin called "mirrored".
"mirrored": {},
}

// IsAdoptableNetworkType returns true if HNS networks of this type can be
// adopted on startup when searching for networks created outside Docker
// (these networks can be added to the network store).
func IsAdoptableNetworkType(networkType string) bool {
_, ok := unadoptableNetworkTypes[strings.ToLower(networkType)]
return !ok
}

func newDriver(networkType string, store *datastore.Store) (*driver, error) {
d := &driver{
name: networkType,
Expand Down
Loading
0