10BC0 Windows: don't try to load "mirrored" network plugin by robmry · Pull Request #50155 · moby/moby · GitHub
[go: up one dir, main page]

Skip to content

Conversation

robmry
Copy link
Contributor
@robmry robmry commented Jun 6, 2025

- What I did

On my Windows laptop, I have some networks with type "mirrored" ...

  • "FSE Switch (Loopback Pseudo-Interface 1)"
  • "FSE Switch (Mobile)"
  • "FSE Switch (WiFi)"
  • "FSE Switch (Ethernet 4)"

On startup, Docker tries to adopt all of the networks it learns about from HNS. But "mirrored" isn't a supported network type, so it tries to load a network plugin called "mirrored". That doesn't exist, so it tries again after 1, 2, 4 and 8 seconds - per network (so, a minute's startup delay in total).

- How I did it

Don't try to load plugin "mirrored".

- How to verify it

Dockerd starts up quickly when the host has "mirrored" networks.

- Human readable description for the release notes

- Windows: Improve daemon startup time in cases where the host has networks of type `"Mirrored"`.

@robmry robmry added this to the 28.2.3 milestone Jun 6, 2025
@robmry robmry self-assigned this Jun 6, 2025
@robmry robmry marked this pull request as ready for review June 9, 2025 08:45
@robmry robmry requested a review from corhere June 9, 2025 09:48
Signed-off-by: Rob Murray <rob.murray@docker.com>
@robmry robmry force-pushed the windows_no_mirrored_plugin branch from f2d7796 to 55f47f9 Compare June 9, 2025 10:38
@robmry
Copy link
Contributor Author
robmry commented Jun 9, 2025

The last push just fixes a comment.

@vvoland vvoland merged commit 52a8109 into moby:master Jun 10, 2025
160 checks passed
@vvoland vvoland modified the milestones: 28.2.3, 28.3.0 Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0