10BC0 Increase max recv gRPC message size for nodes and secrets by dperny · Pull Request #39306 · moby/moby · GitHub
[go: up one dir, main page]
Skip to content

Increase max recv gRPC message size for nodes and secrets #39306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2019
Merged

Increase max recv gRPC message size for nodes and secrets #39306

merged 1 commit into from
Jun 4, 2019
+8 −2

Conversation

dperny
Copy link
Contributor
@dperny dperny commented Jun 3, 2019 •
edited by thaJeztah
Loading

Increases the max recieved gRPC message size for Node and Secret list operations. This has already been done for the other swarm types, but was not done for these.

This helps mitigate errors of this kind, for node and secret ls: rpc error: code = ResourceExhausted desc = grpc: received message larger than max

fixes #37941

thaJeztah
thaJeztah previously approved these changes Jun 3, 2019
View reviewed changes
Copy link
Member
@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah dismissed their stale review June 3, 2019 16:41

whoops; missing an import

@thaJeztah
Copy link
Member

Looks like it's missing an import;

16:38:19 daemon/cluster/nodes.go:1::warning: file is not goimported (goimports)
16:38:19 daemon/cluster/secrets.go:1::warning: file is not goimported (goimports)
16:38:19 daemon/cluster/secrets.go:48:3:warning: undeclared name: grpc (gosimple)
16:38:19 daemon/cluster/nodes.go:34:3:warning: undeclared name: grpc (unconvert)
16:38:19 daemon/cluster/secrets.go:48:3:warning: undeclared name: grpc (unconvert)

@dperny
Increase max recv gRPC message size for nodes and secrets
a0903e1 
Increases the max recieved gRPC message size for Node and Secret list
operations. This has already been done for the other swarm types, but
was not done for these.

Signed-off-by: Drew Erny <drew.erny@docker.com>
@dperny dperny force-pushed the increase-swarmkit-grpc branch from 312a1da to a0903e1 Compare June 3, 2019 16:42
@dperny
Copy link
Contributor Author
dperny commented Jun 3, 2019

Yeah, caught that and fixed it.

thaJeztah
thaJeztah approved these changes Jun 3, 2019
View reviewed changes
Copy link
Member
@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Jun 3, 2019
Merged
Merged
@dperny dperny mentioned this pull request Jun 4, 2019
Closed
@tiborvass tiborvass merged commit 18a4498 into moby:master Jun 4, 2019
@dperny dperny mentioned this pull request Jun 10, 2019
Merged
This was referenced Jul 2, 2019
Merged
Merged
@nmengin nmengin mentioned this pull request Jul 12, 2019
Merged
@thaJeztah thaJeztah mentioned this pull request Sep 6, 2019
Merged
thaJeztah added a commit to thaJeztah/docker that referenced this pull request Sep 12, 2019
@thaJeztah
bump swarmkit to bbe341867eae1615faf8a702ec05bfe986e73e06 (bump_v19.0…
f7dbee3 
…3 branch)

full diff: moby/swarmkit@4fb9e96...bbe3418

changes included:

- moby/swarmkit#2889 [19.03 backport] Fix update out of sequence and increase max recv gRPC message size for nodes and secrets

Which relates to

- moby#39531 integration-cli: fix swarm tests flakiness
- docker-archive#345 [19.03 backport] integration-cli: fix swarm tests flakiness

And includes backports of

- moby/swarmkit#2808 Fix flaky tests
- moby/swarmkit#2866 Swap gometalinter for golangci-lint
- moby/swarmkit#2869 Increase max recv gRPC message size to initialize connection broker
 - related / similar to moby#38103 / docker-archive#102 cluster: set bigger grpc limit for array requests
 - related / similar to moby#39306 Increase max recv gRPC message size for nodes and secrets
 - fixes moby/swarmkit#2733 Error generated when messages size is too big
- moby/swarmkit#2870 Fix update out of sequence

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah mentioned this pull request Sep 12, 2019
Merged
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull request Sep 12, 2019
@thaJeztah
bump swarmkit to bbe341867eae1615faf8a702ec05bfe986e73e06 (bump_v19.0…
e04c04e 
…3 branch)

full diff: moby/swarmkit@4fb9e96...bbe3418

changes included:

- moby/swarmkit#2889 [19.03 backport] Fix update out of sequence and increase max recv gRPC message size for nodes and secrets

Which relates to

- moby/moby#39531 integration-cli: fix swarm tests flakiness
- docker-archive/engine#345 [19.03 backport] integration-cli: fix swarm tests flakiness

And includes backports of

- moby/swarmkit#2808 Fix flaky tests
- moby/swarmkit#2866 Swap gometalinter for golangci-lint
- moby/swarmkit#2869 Increase max recv gRPC message size to initialize connection broker
 - related / similar to moby/moby#38103 / docker-archive/engine#102 cluster: set bigger grpc limit for array requests
 - related / similar to moby/moby#39306 Increase max recv gRPC message size for nodes and secrets
 - fixes moby/swarmkit#2733 Error generated when messages size is too big
- moby/swarmkit#2870 Fix update out of sequence

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Upstream-commit: f7dbee3eeaa1dd218116f85b8f60361acbd5b214
Component: engine
This was referenced Sep 25, 2019
Merged
Merged
@thaJeztah thaJeztah mentioned this pull request Oct 2, 2019
Merged
thaJeztah added a commit to thaJeztah/docker that referenced this pull request Oct 9, 2019
@thaJeztah
[18.09] bump SwarmKit 5c86095cef3ff480e69486da50f18fd1b3a0de78 (bump_…
e06f07e 
…v18.09)

full diff: moby/swarmkit@142a737...5c86095

- moby/swarmkit#2892 [18.09 backport] Remove hardcoded IPAM config subnet value for ingress network
    - backport of moby/swarmkit#2890 Remove hardcoded IPAM config subnet value for ingress network
    - fixes [ENGORC-2651](https://docker.atlassian.net/browse/ENGORC-2651)
- moby/swarmkit#2836 [18.09 backport] Switch to go 1.11
    - backport of moby/swarmkit#2752 Switch to go 1.11
- moby/swarmkit#2901 [18.09 backport] Bump to golang 1.12.9
    - backport of moby/swarmkit#2880 Bump to golang 1.12.9
- moby/swarmkit#2900 [18.09 backport] Fix update out of sequence and increase max recv gRPC message size for nodes and secrets
    - backport of moby/swarmkit#2762 Increased wait time on test utils WaitForCluster and WatchTaskCreate
    - backport of moby/swarmkit#2771 Allow using Configs as CredentialSpecs
        - **second commit only** (attempt to fix weirdly broken tests)
    - backport of moby/swarmkit#2808 Fix flaky tests
    - backport of moby/swarmkit#2866 Swap gometalinter for golangci-lint
    - backport of moby/swarmkit#2869 Increase max recv gRPC message size to initialize connection broker
        - related / similar to moby#38103 / docker-archive#102 cluster: set bigger grpc limit for array requests
        - related / similar to moby#39306 Increase max recv gRPC message size for nodes and secrets
        - fixes moby/swarmkit#2733 Error generated when messages size is too big
    - backport of moby/swarmkit#2870 Fix update out of sequence

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull request Oct 23, 2019
@thaJeztah
[18.09] bump SwarmKit 5c86095cef3ff480e69486da50f18fd1b3a0de78 (bump_…
a7f9149 
…v18.09)

full diff: moby/swarmkit@142a737...5c86095

- moby/swarmkit#2892 [18.09 backport] Remove hardcoded IPAM config subnet value for ingress network
    - backport of moby/swarmkit#2890 Remove hardcoded IPAM config subnet value for ingress network
    - fixes [ENGORC-2651](https://docker.atlassian.net/browse/ENGORC-2651)
- moby/swarmkit#2836 [18.09 backport] Switch to go 1.11
    - backport of moby/swarmkit#2752 Switch to go 1.11
- moby/swarmkit#2901 [18.09 backport] Bump to golang 1.12.9
    - backport of moby/swarmkit#2880 Bump to golang 1.12.9
- moby/swarmkit#2900 [18.09 backport] Fix update out of sequence and increase max recv gRPC message size for nodes and secrets
    - backport of moby/swarmkit#2762 Increased wait time on test utils WaitForCluster and WatchTaskCreate
    - backport of moby/swarmkit#2771 Allow using Configs as CredentialSpecs
        - **second commit only** (attempt to fix weirdly broken tests)
    - backport of moby/swarmkit#2808 Fix flaky tests
    - backport of moby/swarmkit#2866 Swap gometalinter for golangci-lint
    - backport of moby/swarmkit#2869 Increase max recv gRPC message size to initialize connection broker
        - related / similar to moby/moby#38103 / docker-archive/engine#102 cluster: set bigger grpc limit for array requests
        - related / similar to moby/moby#39306 Increase max recv gRPC message size for nodes and secrets
        - fixes moby/swarmkit#2733 Error generated when messages size is too big
    - backport of moby/swarmkit#2870 Fix update out of sequence

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Upstream-commit: e06f07ef337ab890f211397d6b408b75a2512dc5
Component: engine
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 2, 2020
@IMMORTALxJO IMMORTALxJO mentioned this pull request Jul 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiborvass tiborvass tiborvass approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
area/swarm process/cherry-picked status/2-code-review
Projects
None yet
Milestone
20.10.0
Development

Successfully merging this pull request may close these issues.

Unhealthy cluster: grpc: received message larger than max (4246471 vs. XXXX)
5 participants
@dperny @thaJeztah @tiborvass @yongtang @GordonTheTurtle
0