8000 [18.09 backport] Increase max recv gRPC message size for nodes and secrets by thaJeztah · Pull Request #257 · docker-archive/engine · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

Conversation

thaJeztah
Copy link
Member

backport of moby#39306 for 18.09

Increases the max recieved gRPC message size for Node and Secret list
operations. This has already been done for the other swarm types, but
was not done for these.

Signed-off-by: Drew Erny drew.erny@docker.com
(cherry picked from commit a0903e1)
Signed-off-by: Sebastiaan van Stijn github@gone.nl

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Increases the max recieved gRPC message size for Node and Secret list
operations. This has already been done for the other swarm types, but
was not done for these.

Signed-off-by: Drew Erny <drew.erny@docker.com>
(cherry picked from commit a0903e1)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 18.09.7 milestone Jun 3, 2019
@thaJeztah
Copy link
Member Author

ping @kolyshkin @dperny PTAL

@dperny
Copy link
dperny commented Jun 4, 2019

LGTM

@thaJeztah thaJeztah changed the title [18.09 backport] Increase max recv gRPC message size for nodes and secrets [WIP][18.09 backport] Increase max recv gRPC message size for nodes and secrets Jun 4, 2019
@thaJeztah
Copy link
Member Author

marked "WIP", awaiting upstream to be merged

@thaJeztah thaJeztah changed the title [WIP][18.09 backport] Increase max recv gRPC message size for nodes and secrets [18.09 backport] Increase max recv gRPC message size for nodes and secrets Jun 4, 2019
andrewhsu
Copy link
@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit ce2e2b6 into docker-archive:18.09 Jun 17, 2019
@thaJeztah thaJeztah deleted the 18.09_backport_increase_swarmkit_grpc branch June 17, 2019 19:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0