E53B cmd/buildkitd: move reexec.Init to non-Linux files by thaJeztah · Pull Request #5659 · moby/buildkit · GitHub
[go: up one dir, main page]
Skip to content

cmd/buildkitd: move reexec.Init to non-Linux files #5659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2025
Merged

cmd/buildkitd: move reexec.Init to non-Linux files #5659

merged 1 commit into from
Jan 15, 2025

Conversation

thaJeztah
Copy link
Member
@thaJeztah thaJeztah commented Jan 14, 2025 •
edited
Loading

reexec is only used on Windows and BSD for;

  • util/system/getuserinfo (lookup user information)
  • source/git (git operations)

updates 698acd3

@thaJeztah thaJeztah self-assigned this Jan 14, 2025
@thaJeztah thaJeztah requested a review from tonistiigi January 14, 2025 23:55
@thaJeztah thaJeztah mentioned this pull request Jan 14, 2025
Merged
tonistiigi
tonistiigi requested changes Jan 14, 2025
View reviewed changes
Copy link
Member
@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need this in freebsd etc. Anything but linux.

@thaJeztah
Copy link
Member Author

doh! forgot this repo also supports BSD; let me fix

@thaJeztah
cmd/buildkitd: move reexec.Init to non-Linux files
e1d393e 
reexec is only used on Windows and BSD for;

- util/system/getuserinfo (lookup user information)
- source/git (git operations)

updates 698acd3

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the reexec_windows_only branch from f8e3cdc to e1d393e Compare January 15, 2025 00:10
@thaJeztah thaJeztah changed the title cmd/buildkitd: move reexec.Init to windows-only files cmd/buildkitd: move reexec.Init to non-Linux files Jan 15, 2025
@thaJeztah
Copy link
Member Author

updated

@tonistiigi tonistiigi merged commit f33e27e into moby:master Jan 15, 2025
96 checks passed
@thaJeztah thaJeztah deleted the reexec_windows_only branch January 15, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

Assignees

@thaJeztah thaJeztah

Labels
area/buildkitd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thaJeztah @tonistiigi
0