E53E migrate to github.com/moby/sys/reexec by thaJeztah · Pull Request #5605 · moby/buildkit · GitHub
[go: up one dir, main page]
Skip to content

migrate to github.com/moby/sys/reexec #5605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2024
Merged

migrate to github.com/moby/sys/reexec #5605

merged 1 commit into from
Dec 20, 2024

Conversation

thaJeztah
Copy link
Member

The github.com/docker/docker/pkg/reexec package was moved to a separate module; migrate to use that module instead.

@thaJeztah thaJeztah self-assigned this Dec 18, 2024
@thaJeztah
migrate to github.com/moby/sys/reexec
698acd3 
The github.com/docker/docker/pkg/reexec package was moved to
a separate module; migrate to use that module instead.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah marked this pull request as ready for review December 18, 2024 20:11
@thaJeztah thaJeztah mentioned this pull request Dec 19, 2024
Merged
This was referenced Dec 19, 2024
Merged
Open
tonistiigi
tonistiigi approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member
@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be followed-up by removing the import from main.go as no linux codepath uses this pkg.

@tonistiigi tonistiigi merged commit ee725f1 into moby:master Dec 20, 2024
97 checks passed
@thaJeztah thaJeztah deleted the migrate_reexec branch January 14, 2025 23:44
@thaJeztah thaJeztah mentioned this pull request Jan 14, 2025
Merged
@thaJeztah
Copy link
Member Author

This should be followed-up by removing the import from main.go as no linux codepath uses this pkg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@crazy-max crazy-max Awaiting requested review from crazy-max

Assignees

@thaJeztah thaJeztah

Labels
area/buildkitd area/dependencies Pull requests that update a dependency file area/source area/util area/windows needs/follow-up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thaJeztah @tonistiigi @AkihiroSuda
0