8000 Revert "Correctly log unit test error logs" by karrtikr · Pull Request #10187 · microsoft/vscode-python · GitHub
[go: up one dir, main page]
Skip to content

Revert "Correctly log unit test error logs" #10187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Revert "Correctly log unit test error logs" #10187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/client/testing/unittest/runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import { inject, injectable } from 'inversify';
import * as path from 'path';
import { EXTENSION_ROOT_DIR } from '../../common/constants';
import { traceError, traceInfo } from '../../common/logger';
import { traceError } from '../../common/logger';
import { IDisposableRegistry } from '../../common/types';
import { createDeferred, 6D28 Deferred } from '../../common/utils/async';
import { noop } from '../../common/utils/misc';
Expand Down Expand Up @@ -74,8 +74,8 @@ export class TestManagerRunner implements ITestManagerRunner {
options.tests.summary.skipped = 0;
let failFast = false;
const testLauncherFile = path.join(EXTENSION_ROOT_DIR, 'pythonFiles', 'visualstudio_py_testlauncher.py');
this.server.on('error', traceError);
this.server.on('log', (message: string, ...data: string[]) => traceInfo(`${message} ${data.join(' ')}`));
this.server.on('error', (message: string, ...data: string[]) => traceError(`${message} ${data.join(' ')}`));
this.server.on('log', noop);
this.server.on('connect', noop);
this.server.on('start', noop);
this.server.on('result', (data: ITestData) => {
Expand Down
0