8000 Revert "Correctly log unit test error logs" by karrtikr · Pull Request #10187 · microsoft/vscode-python · GitHub
[go: up one dir, main page]
Skip to content

Revert "Correctly log unit test error logs" #10187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2020
Merged

Revert "Correctly log unit test error logs" #10187

merged 1 commit into from
Feb 18, 2020

Conversation

karrtikr
Copy link

Reverts #10120

@karrtikr karrtikr added the no-changelog No news entry required label Feb 18, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kimadeline kimadeline self-requested a review February 18, 2020 22:43
@codecov-io
Copy link
codecov-io commented Feb 18, 2020 •
edited
Loading

Codecov Report

Merging #10187 into master will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10187   +/-   ##
=======================================
  Coverage   61.31%   61.31%           
=======================================
  Files         567      567           
  Lines       30770    30770           
  Branches     4410     4410           
=======================================
  Hits        18868    18868           
  Misses      10918    10918           
  Partials      984      984
Impacted Files Coverage Δ
src/client/testing/unittest/runner.ts 14.4% <33.33%> (ø) ⬆️
src/client/common/process/proc.ts 15.21% <0%> (ø) ⬆️
src/client/datascience/debugLocationTracker.ts 78.12% <0%> (ø) ⬆️
src/client/linters/pydocstyle.ts 88.88% <0%> (ø) ⬆️
src/client/common/utils/platform.ts 76.47% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cf2872...d4b848e. Read the comment docs.

@karrtikr karrtikr merged commit 88f38ec into master Feb 18, 2020
@karrtikr karrtikr deleted the revert-10120-unitlog branch February 18, 2020 22:55
@lock lock bot locked as resolved and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kimadeline kimadeline kimadeline approved these changes

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karrtikr @codecov-io @kimadeline
0