8000 Adding Recognizer interface to LuisRecognizer by axelsrz · Pull Request #326 · microsoft/botbuilder-python · GitHub
[go: up one dir, main page]
Skip to content

Adding Recognizer interface to LuisRecognizer #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2019
Merged

Adding Recognizer interface to LuisRecognizer #326

merged 2 commits into from
Oct 1, 2019

Conversation

axelsrz
Copy link
Member
@axelsrz axelsrz commented Sep 30, 2019

Fixes #254

@axelsrz axelsrz requested a review from daveta September 30, 2019 17:50
@axelsrz axelsrz requested a review from stevengum September 30, 2019 20:44
daveta
daveta reviewed Sep 30, 2019
View reviewed changes
libraries/botbuilder-ai/botbuilder/ai/luis/luis_recognizer.py
from botbuilder.schema import ActivityTypes

from . import LuisApplication, LuisPredictionOptions, LuisTelemetryConstants
from .activity_util import ActivityUtil
from .luis_util import LuisUtil


class LuisRecognizer:
class LuisRecognizer(Recognizer):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm - not sure if this is for Luis V3 or old one, but looking at C#, there's another level of TelemetryRecognizer if you want to be faithful to that..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old one. Yes, but that interface only provide more method overloading (not supported in python) and attributes (not supported in the ABC pattern), making it redundant.

The idea here is to provide an interface that can be used at testing, where this ABC is sufficient.

daveta
daveta approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor
@daveta daveta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@axelsrz axelsrz merged commit 65f73d0 into master Oct 1, 2019
@axelsrz axelsrz deleted the axsuarez/luis-recognizer-interface-fix branch October 1, 2019 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daveta daveta daveta approved these changes

@stevengum stevengum Awaiting requested review from stevengum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LuisRecognizer is missing use of interface
2 participants
@axelsrz @daveta
0