Adding Recognizer interface to LuisRecognizer #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveta
reviewed
Sep 30, 2019
| from botbuilder.schema import ActivityTypes | ||
|
|
||
| from . import LuisApplication, LuisPredictionOptions, LuisTelemetryConstants | ||
| from .activity_util import ActivityUtil | ||
| from .luis_util import LuisUtil | ||
|
|
||
|
|
||
| class LuisRecognizer: | ||
| class LuisRecognizer(Recognizer): |
There was a problem hiding this comment.
Hmm - not sure if this is for Luis V3 or old one, but looking at C#, there's another level of TelemetryRecognizer if you want to be faithful to that..
There was a problem hiding this comment.
Old one. Yes, but that interface only provide more method overloading (not supported in python) and attributes (not supported in the ABC pattern), making it redundant.
The idea here is to provide an interface that can be used at testing, where this ABC is sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #254