E540 moby-engine: remove daemon.json with backported fix by hbeberman · Pull Request #9551 · microsoft/azurelinux · GitHub
[go: up one dir, main page]
Skip to content

moby-engine: remove daemon.json with backported fix #9551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2024
Merged

moby-engine: remove daemon.json with backported fix #9551

merged 2 commits into from
Jul 16, 2024

Conversation

hbeberman
Copy link
Member
@hbeberman hbeberman commented Jul 1, 2024 •
edited
Loading
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • If you are adding/removing a .spec file that has multiple-versions supported, please add @microsoft/cbl-mariner-multi-package-reviewers team as reviewer (Eg. golang has 2 versions 1.18, 1.21+)
  • Ready to merge
Summary

Our moby-engine-24.0.9-1 package brought in a new daemon.json file to inform the newer moby-engine version of docker-proxy's location. Adding daemon.json to the package regressed several use cases, instead we'll rely on backporting a recent upstream change (moby/moby#47804) that implicitly looks for docker-proxy in libexec so that we can drop daemon.json.

Change Log
Does this affect the toolchain?

NO

Associated issues
Test Methodology
  • Local package build
  • Buddy build: succeeded
  • Package upgrade on a running system. Verified that moby-engine is able to find docker-proxy after the upgrade.

@hbeberman hbeberman requested a review from a team as a code owner July 1, 2024 22:50
@hbeberman hbeberman added the 2.0 AzureLinux 2.0 label Jul 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label Jul 1, 2024
@hbeberman hbeberman added bug Something isn't working and removed main PR Destined for main labels Jul 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label Jul 1, 2024
@mfrw mfrw added the stable-release-shiproom PRs for consideration for stable shiproom label Jul 4, 2024
mfrw
mfrw reviewed Jul 4, 2024
View reviewed changes
christopherco
christopherco reviewed Jul 5, 2024
View reviewed changes
@hbeberman hbeberman merged commit af186a1 into main Jul 16, 2024
@hbeberman hbeberman deleted the hbeberman/moby-search-path-backport branch July 16, 2024 17:10
hbeberman added a commit that referenced this pull request Jul 16, 2024
@hbeberman
moby-engine: remove daemon.json with backported fix (#9551)
b4f4d7a
@hbeberman hbeberman mentioned this pull request Jul 16, 2024
Merged
13 tasks
PawelWMS pushed a commit that referenced this pull request Jul 16, 2024
@hbeberman
moby-engine: remove daemon.json with backported fix (#9551) (#9851)
77d3928
@hbeberman hbeberman mentioned this pull request Aug 9, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfrw mfrw mfrw left review comments

@christopherco christopherco christopherco approved these changes

Assignees
No one assigned
Labels
2.0 AzureLinux 2.0 bug Something isn't working main PR Destined for main stable-release-shiproom PRs for consideration for stable shiproom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbeberman @mfrw @christopherco
0