8000 moby-engine: remove daemon.json with backported fix by hbeberman · Pull Request #10094 · microsoft/azurelinux · GitHub
[go: up one dir, main page]
Skip to content

moby-engine: remove daemon.json with backported fix #10094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2024
Merged

moby-engine: remove daemon.json with backported fix #10094

merged 1 commit into from
Aug 9, 2024

Conversation

hbeberman
Copy link
Member
@hbeberman hbeberman commented Aug 9, 2024 •
edited
Loading
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

When upgrading to moby-engine version 25 we brought in a new daemon.json file to inform the newer moby-engine version of docker-proxy's location. Adding daemon.json to the package regressed several use cases, instead we'll rely on backporting a recent upstream change (moby/moby#47804) that implicitly looks for docker-proxy in libexec so that we can drop daemon.json.

Change Log
Does this affect the toolchain?

NO

Associated issues
Test Methodology

@hbeberman hbeberman requested a review from a team as a code owner August 9, 2024 21:08
@hbeberman hbeberman merged commit b59f928 into 3.0-dev Aug 9, 2024
@hbeberman hbeberman deleted the hbeberman/3.0/moby-search-path branch August 9, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christopherco christopherco christopherco approved these changes

Assignees

No one assigned

Labels

Packaging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hbeberman @christopherco
0