8000 Add MSC support for ESP32 S3 by M-D-777 · Pull Request #8699 · micropython/micropython · GitHub
[go: up one dir, main page]

Skip to content

Add MSC support for ESP32 S3 #8699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ports/esp32/boards/GENERIC_S3/mpconfigboard.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ set(IDF_TARGET esp32s3)
set(SDKCONFIG_DEFAULTS
boards/sdkconfig.base
boards/sdkconfig.usb
#boards/sdkconfig.usb_msc
boards/sdkconfig.ble
boards/GENERIC_S3/sdkconfig.board
)
6 changes: 6 additions & 0 deletions ports/esp32/boards/sdkconfig.usb_msc
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#
# Massive Storage Class (MSC)
#
CONFIG_USB_MSC_ENABLED=y
CONFIG_USB_MSC_BUFSIZE=4096
# end of Massive Storage Class (MSC)
1 change: 1 addition & 0 deletions ports/esp32/main/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ set(MICROPY_SOURCE_PORT
${PROJECT_DIR}/uart.c
${PROJECT_DIR}/usb.c
${PROJECT_DIR}/usb_serial_jtag.c
${PROJECT_DIR}/usb_msc.c
${PROJECT_DIR}/gccollect.c
${PROJECT_DIR}/mphalport.c
${PROJECT_DIR}/fatfs_port.c
Expand Down
6 changes: 4 additions & 2 deletions ports/esp32/modules/inisetup.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,10 @@ def fs_corrupted():
def setup():
check_bootsec()
print("Performing initial setup")
uos.VfsLfs2.mkfs(bdev)
vfs = uos.VfsLfs2(bdev)
# uos.VfsLfs2.mkfs(bdev)
Copy link
@PGNetHun PGNetHun May 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change default LittleFS to FAT, as file is shared among all ESP32 variants (freeze in manifest.py).
Best way would be to override inisetup.py file in board folder with a custom manifest.py, similar to UM_TINYS2 board's manifest.py file

# vfs = uos.VfsLfs2(bdev)
uos.VfsFat.mkfs(bdev)
vfs = uos.VfsFat(bdev)
uos.mount(vfs, "/")
with open("boot.py", "w") as f:
f.write(
Expand Down
4 changes: 4 additions & 0 deletions ports/esp32/usb.c
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@ void usb_init(void) {
usb_cdc_connected = 0;
ESP_ERROR_CHECK(tusb_cdc_acm_init(&amc_cfg));

#if CONFIG_USB_MSC_ENABLED
ESP_ERROR_CHECK(usb_msc_init());
#endif // CONFIG_USB_MSC_ENABLED

}

void usb_tx_strn(const char *str, size_t len) {
Expand Down
1 change: 1 addition & 0 deletions ports/esp32/usb.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
*/
#ifndef MICROPY_INCLUDED_ESP32_USB_H
#define MICROPY_INCLUDED_ESP32_USB_H
#include "usb_msc.h"

void usb_init(void);
void usb_tx_strn(const char *str, size_t len);
Expand Down
154 changes: 154 additions & 0 deletions ports/esp32/usb_msc.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,154 @@
/*
* The MIT License (MIT)
*
* Copyright (c) 2020-2021 Damien P. George
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
*
*/
#include "usb_msc.h"
#if CONFIG_USB_MSC_ENABLED
#include "esp_err.h"
#include "esp_log.h"
#include "esp_partition.h"

#define BLOCK_SIZE (CFG_TUD_MSC_BUFSIZE)

static bool ejected = false;

const esp_partition_t *partition;
esp_err_t usb_msc_init()
{
partition = esp_partition_find_first(ESP_PARTITION_TYPE_DATA, ESP_PARTITION_SUBTYPE_ANY, "vfs");
assert(partition != NULL);
ESP_LOGD(__func__, "");
return ESP_OK;
}

// Invoked when received SCSI_CMD_INQUIRY
// Application fill vendor id, product id and revision with string up to 8, 16, 4 characters respectively
void tud_msc_inquiry_cb(uint8_t lun, uint8_t vendor_id[8], uint8_t product_id[16], uint8_t product_rev[4])
{
const char vid[] = "Micropy";
const char pid[] = "Mass Storage";
const char rev[] = "1.0";

memcpy(vendor_id, vid, strlen(vid));
memcpy(product_id, pid, strlen(pid));
memcpy(product_rev, rev, strlen(rev));
}

// Invoked when received Test Unit Ready command.
// return true allowing host to read/write this LUN e.g SD card inserted
bool tud_msc_test_unit_ready_cb(uint8_t lun)
{
if (ejected) {
// Set 0x3a for media not present.
tud_msc_set_sense(lun, SCSI_SENSE_NOT_READY, 0x3A, 0x00);
return false;
}
return true;
}

// Invoked when received SCSI_CMD_READ_CAPACITY_10 and SCSI_CMD_READ_FORMAT_CAPACITY to determine the disk size
// Application update block count and block size
void tud_msc_capacity_cb(uint8_t lun, uint32_t *block_count, uint16_t *block_size)
{
*block_size = BLOCK_SIZE;
*block_count = partition->size / BLOCK_SIZE;
}

// Invoked when received Start Stop Unit command
// - Start = 0 : stopped power mode, if load_eject = 1 : unload disk storage
// - Start = 1 : active mode, if load_eject = 1 : load disk storage
bool tud_msc_start_stop_cb(uint8_t lun, uint8_t power_condition, bool start, bool load_eject)
{
if (load_eject) {
if (!start) {
ejected = true;
} else {
// We can only load if it hasn't been ejected.
ejected = false;
}
} else {
// Always start the unit, even if ejected. Whether media is present is a separate check.
}

return true;
}

// Callback invoked when received READ10 command.
// Copy disk's data to buffer (up to bufsize) and return number of copied bytes.
int32_t tud_msc_read10_cb(uint8_t lun, uint32_t lba, uint32_t offset, void *buffer, uint32_t bufsize)
{
ESP_ERROR_CHECK(esp_partition_read(partition, lba * BLOCK_SIZE, buffer, bufsize));
return bufsize;
}

// Callback invoked when received WRITE10 command.
// Process data in buffer to disk's storage and return number of written bytes
int32_t tud_msc_write10_cb(uint8_t lun, uint32_t lba, uint32_t offset, uint8_t *buffer, uint32_t bufsize)
{
ESP_ERROR_CHECK(esp_partition_erase_range(partition, lba * BLOCK_SIZE, bufsize));
ESP_ERROR_CHECK(esp_partition_write(partition, lba * BLOCK_SIZE, buffer, bufsize));
return bufsize;
}

// Callback invoked when received an SCSI command not in built-in list below
// - READ_CAPACITY10, READ_FORMAT_CAPACITY, INQUIRY, MODE_SENSE6, REQUEST_SENSE
// - READ10 and WRITE10 has their own callbacks
int32_t tud_msc_scsi_cb(uint8_t lun, uint8_t const scsi_cmd[16], void *buffer, uint16_t bufsize)
{
void const *response = NULL;
uint16_t resplen = 0;

// most scsi handled is input
bool in_xfer = true;

switch (scsi_cmd[0]) {
case SCSI_CMD_PREVENT_ALLOW_MEDIUM_REMOVAL:
// Host is about to read/write etc ... better not to disconnect disk
resplen = 0;
break;

default:
// Set Sense = Invalid Command Operation
tud_msc_set_sense(lun, SCSI_SENSE_ILLEGAL_REQUEST, 0x20, 0x00);

// negative means error -> tinyusb could stall and/or response with failed status
resplen = -1;
break;
}

// return resplen must not larger than bufsize
if (resplen > bufsize) {
resplen = bufsize;
}

if (response && (resplen > 0)) {
if (in_xfer) {
memcpy(buffer, response, resplen);
} else {
// SCSI output
}
}

return resplen;
}
#endif // CONFIG_USB_MSC_ENABLED
47 changes: 47 additions & 0 deletions ports/esp32/usb_msc.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
/*
* This file is part of the MicroPython project, http://micropython.org/
*
* The MIT License (MIT)
*
* Copyright (c) 2021 Damien P. George
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
*/

#pragma once

#ifdef __cplusplus
extern "C" {
#endif

#include <stdint.h>
#include "tusb.h"
#include "tinyusb.h"

/**
* @brief Initialize MSC Device.
*
* @param cfg - init configuration structure
* @return esp_err_t
*/
esp_err_t usb_msc_init();

#ifdef __cplusplus
}
#endif
0