-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Add MSC support for ESP32 S3 #8699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -33,8 +33,10 @@ def fs_corrupted(): | |||
def setup(): | |||
check_bootsec() | |||
print("Performing initial setup") | |||
uos.VfsLfs2.mkfs(bdev) | |||
vfs = uos.VfsLfs2(bdev) | |||
# uos.VfsLfs2.mkfs(bdev) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not change default LittleFS
to FAT
, as file is shared among all ESP32 variants (freeze in manifest.py).
Best way would be to override inisetup.py
file in board folder with a custom manifest.py
, similar to UM_TINYS2
board's manifest.py file
I've tested this patch and it works perfectly, however I can see these changes would affect other boards, please limit the changes to only the S3 boards. |
Hi, @PGNetHun I have added custom manifest.py for msc boot fatfs. |
If you could add that change to all of the s3 variants that would be mint |
All of the S3 and S2 variants will be great. I will test and confirm the ESP32 S2 MSC feature, then push a commit. |
By default, the usb feature is disabled by #boards/sdkconfig.usb_msc in mpconfigboard.cmake.
@Red-M @PGNetHun Hi, All. I have confirmed the USB MSC feature is compatible with ESP32 S2. So I add this feature to all of the ESP32 S2 and S3 variants. |
# Conflicts: # ports/esp32/boards/GENERIC_S3_SPIRAM/mpconfigboard.cmake
Make SD cards available over web workflow
Hi, all
Any interest in adding MSC support for ESP32 S3?
The MSC feature is configurable with sdkconfig.usb_msc.