8000 Add MSC support for ESP32 S3 by M-D-777 · Pull Request #8699 · micropython/micropython · GitHub
[go: up one dir, main page]

Skip to content

Add MSC support for ESP32 S3 #8699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

M-D-777
Copy link
@M-D-777 M-D-777 commented May 25, 2022

Hi, all

Any interest in adding MSC support for ESP32 S3?

The MSC feature is configurable with sdkconfig.usb_msc.

@@ -33,8 +33,10 @@ def fs_corrupted():
def setup():
check_bootsec()
print("Performing initial setup")
uos.VfsLfs2.mkfs(bdev)
vfs = uos.VfsLfs2(bdev)
# uos.VfsLfs2.mkfs(bdev)
Copy link
@PGNetHun PGNetHun May 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change default LittleFS to FAT, as file is shared among all ESP32 variants (freeze in manifest.py).
Best way would be to override inisetup.py file in board folder with a custom manifest.py, similar to UM_TINYS2 board's manifest.py file

@Red-M
Copy link
Contributor
Red-M commented May 28, 2022

I've tested this patch and it works perfectly, however I can see these changes would affect other boards, please limit the changes to only the S3 boards.

@M-D-777
Copy link
Author
M-D-777 commented May 29, 2022

@PGNetHun @Red-M Thanks for your review. I will update a commit later.

@M-D-777
Copy link
Author
M-D-777 commented Jun 1, 2022

Hi, @PGNetHun I have added custom manifest.py for msc boot fatfs.
Please review the newest commit, thanks.

@Red-M
Copy link
Contributor
Red-M commented Jun 1, 2022

If you could add that change to all of the s3 variants that would be mint

@M-D-777
Copy link
Author
M-D-777 commented Jun 1, 2022

If you could add that change to all of the s3 variants that would be mint

All of the S3 and S2 variants will be great. I will test and confirm the ESP32 S2 MSC feature, then push a commit.

By default, the usb feature is disabled by #boards/sdkconfig.usb_msc in mpconfigboard.cmake.
@M-D-777
Copy link
Author
M-D-777 commented Jun 3, 2022

@Red-M @PGNetHun Hi, All. I have confirmed the USB MSC feature is compatible with ESP32 S2. So I add this feature to all of the ESP32 S2 and S3 variants.
By default, the usb feature is disabled by #boards/sdkconfig.usb_msc in mpconfigboard.cmake.
Do we need to enable the USB MSC feature by default, just like USB CDC?

# Conflicts:
#	ports/esp32/boards/GENERIC_S3_SPIRAM/mpconfigboard.cmake
@M-D-777 M-D-777 closed this Nov 26, 2022
@M-D-777 M-D-777 deleted the feature/ESP32_S3_USB_MSC branch November 26, 2022 07:46
tannewt added a commit to tannewt/circuitpython that referenced this pull request Jan 25, 2024
Make SD cards available over web workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0