8000 stm32/can: Fix clearing filters on CAN3 (bxCAN). by projectgus · Pull Request #16545 · micropython/micropython · GitHub
[go: up one dir, main page]
Skip to content

stm32/can: Fix clearing filters on CAN3 (bxCAN). #16545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2025
Merged

stm32/can: Fix clearing filters on CAN3 (bxCAN). #16545

merged 1 commit into from
Jan 17, 2025

Conversation

projectgus
Copy link
Contributor

Summary

This fix was split out from #15989.

The instance argument to HAL_CAN_ConfigFilter() is ignored for CAN1, CAN2 but needed for CAN3.

Testing

@github-actions GitHub Actions
Copy link
github-actions bot commented Jan 8, 2025

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +4 +0.001% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

@projectgus projectgus mentioned this pull request Jan 8, 2025
Merged
@projectgus @dpgeorge
stm32/can: Fix clearing filters on CAN3 (bxCAN).
3a60f32 
HAL argument is ignored for CAN1, CAN2 but needed for CAN3.

Signed-off-by: Angus Gratton <angus@redyak.com.au>
@dpgeorge dpgeorge force-pushed the bugfix/stm32_can3_clear_filter branch from dca3580 to 3a60f32 Compare January 17, 2025 02:08
@dpgeorge dpgeorge merged commit 3a60f32 into micropython:master Jan 17, 2025
10 checks passed
@projectgus projectgus deleted the bugfix/stm32_can3_clear_filter branch January 17, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgeorge dpgeorge dpgeorge approved these changes

Assignees
No one assigned
Labels
port-stm32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@projectgus @dpgeorge
0