8000 esp32: Freeze aioespnow module into ESP32 firmware by default. by glenn20 · Pull Request #12582 · micropython/micropython · GitHub
[go: up one dir, main page]
Skip to content

esp32: Freeze aioespnow module into ESP32 firmware by default. #12582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2023
Merged

esp32: Freeze aioespnow module into ESP32 firmware by default. #12582

merged 1 commit into from
Oct 5, 2023

Conversation

glenn20
Copy link
Contributor
@glenn20 glenn20 commented Oct 4, 2023

Uncomment the # require("aioespnow") line in ports/esp32/boards/manifest.py as proposed in #12580.

This PR can be merged after the lib/micropython-lib submodule is updated to a revision which includes micropython/aioespnow/aioespnow.py. This is expected to occur prior to the release of v1.21.0.

aioespnow extends the espnow module with support for asyncio methods: arecv() and asend() and is documented in the espnow documentation.

Fixes #12580

@glenn20
Copy link
Contributor Author
glenn20 commented Oct 4, 2023 •
edited
Loading

Checks are failing due to missing aioespnow.py. This will be resolved once lib/micropython-lib submodule is updated.

@dpgeorge
Copy link
Member
dpgeorge commented Oct 5, 2023

The micropython-lib submodule has been updated.

What about esp8266? I'm not sure this has enough space to freeze aioespnow, so it would be good to remove that require() line from its manifest file.

@glenn20
Copy link
Contributor Author
glenn20 commented Oct 5, 2023

I'm not sure this has enough space to freeze aioespnow, so it would be good to remove that require() line from its manifest file.

Good point. I forgot about that commented lin in the esp8266 manifest. I'll fix shortly.

@glenn20 glenn20 force-pushed the feature-freeze-aioespnow branch 2 times, most recently from e482ed6 to ff0eeb5 Compare October 5, 2023 07:45
@glenn20
Copy link
Contributor Author
glenn20 commented Oct 5, 2023

Done.

@glenn20 glenn20 force-pushed the feature-freeze-aioespnow branch from ff0eeb5 to 77724d6 Compare October 5, 2023 09:28
@glenn20 @dpgeorge
esp32/boards/manifest.py: Freeze aioespnow into firmware by default.
f0f173f 
Also remove corresponding commented line from esp8266/boards/manifest.py.
It doesn't have enough flash to have this frozen by default.

Signed-off-by: Glenn Moloney <glenn.moloney@gmail.com>
@dpgeorge dpgeorge force-pushed the feature-freeze-aioespnow branch from 77724d6 to f0f173f Compare October 5, 2023 09:52
@dpgeorge dpgeorge merged commit f0f173f into micropython:master Oct 5, 2023
@dpgeorge
Copy link
Member
dpgeorge commented Oct 5, 2023

Thanks for updating.

@glenn20 glenn20 deleted the feature-freeze-aioespnow branch October 5, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
port-esp32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

espnow: Resolve availability of aioespnow prior to v1.21 release
2 participants
@glenn20 @dpgeorge
0