8000 espnow: Resolve availability of aioespnow prior to v1.21 release · Issue #12580 · micropython/micropython · GitHub
[go: up one dir, main page]
Skip to content

espnow: Resolve availability of aioespnow prior to v1.21 release #12580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
glenn20 opened this issue Oct 4, 2023 · 2 comments · Fixed by #12582
Closed

espnow: Resolve availability of aioespnow prior to v1.21 release #12580

glenn20 opened this issue Oct 4, 2023 · 2 comments · Fixed by #12582

Comments

@glenn20
Copy link
Contributor
glenn20 commented Oct 4, 2023

The aioespnow module is now available in micropython-lib. However, it is unclear how users are intended to access the aioespnow module once v1.21.0 is released. There are two options:

  1. Uncomment # require("aioespnow") in ports/esp32/boards/manifest.py so that aioespnow.py is frozen into esp32 firmware by default (as suggested in PR esp32: ESP-NOW support for ESP32 and ESP8266 #6515)
    • This should be done after updating the micropython-lib submodule reference in micropython from c113611 and before releasing v1.21.0.
    • This requires no changes to the existing documentation

OR

  1. Update docs/library/espnow.html to indicate that the aioespnow modules should be installed with mip.
    • and remove the commented line in ports/esp32/boards/manifest.py.

I am seeking guidance and will submit a PR accordingly. Without action, the documentation will be incomplete/inconsistent with respect to use of aioespnow when v1.21.0 is released.
@dpgeorge
Copy link
Member
dpgeorge commented Oct 4, 2023

Let's go for option 1. micropython-lib will be updated here shortly.

@glenn20
Copy link
Contributor Author
glenn20 commented Oct 4, 2023

Great - thanks. I'll submit a one-liner PR (which will fail commit checks till micropython-lib is updated) - unless you prefer to handle it yourself ;).

@glenn20 glenn20 mentioned this issue Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

esp32: Freeze aioespnow module into ESP32 firmware by default. glenn20/micropython
2 participants
@dpgeorge @glenn20
0