8000 tools/autobuild: Add support for application .bin files for esp32. by dpgeorge · Pull Request #12081 · micropython/micropython · GitHub
[go: up one dir, main page]
Skip to content

tools/autobuild: Add support for application .bin files for esp32. #12081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2023
Merged

tools/autobuild: Add support for application .bin files for esp32. #12081

merged 1 commit into from
Jul 27, 2023

Conversation

dpgeorge
Copy link
Member

On esp32, the build output consists of:

  • micropython.elf
  • micropython.map
  • micropython.bin -- application only
  • micropython.uf2 -- application only
  • firmware.bin -- bootloader, partition table and application

Currently everything is available at the download page except micropython.bin. This commit adds that file but with the extension changed to .app_bin, to distinguish it from .bin (the full thing).

Eg for the generic esp32 port the file would be esp32-20230426-v1.20.0.app_bin. For a nightly build it would be esp32-20230724-unstable-v1.20.0-312-g8ef5622b9.app_bin.

8000
@dpgeorge dpgeorge added the tools Relates to tools/ directory in source, or other tooling label Jul 24, 2023
@dpgeorge
Copy link
Member Author

@iabdalkader does this work for you? Due to the way the auto-build system works, it's much easier to have the name differ only by the extension (rather than, eg, <board>-<version>-main-app.bin).

@iabdalkader
Copy link
Contributor

does this work for you? Due to the way the auto-build system works, it's much easier to have the name differ only by the extension (rather than, eg, <board>-<version>-main-app.bin).

It should be the same, CC @sebromero

@dpgeorge
Copy link
Member Author

It should be the same

Sorry, do you mean yes it will work, or no it won't because the extension needs to be .bin?

@iabdalkader
Copy link
Contributor

Sorry, do you mean yes it will work, or no it won't because the extension needs to be .bin?

I mean yes it's just a binary file. I've mentioned Sebastian to confirm since he asked for the separate binary.

@github-actions
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% PICO
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS

@codecov
Copy link
codecov bot commented Jul 24, 2023 •
edited
Loading

Codecov Report

Merging #12081 (d14ddcb) into master (cfcce4b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #12081   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         157      157           
  Lines       20703    20703           
=======================================
  Hits        20368    20368           
  Misses        335      335

@sebromero
Copy link
Contributor
sebromero commented Jul 26, 2023 •
edited
Loading

@dpgeorge Thanks for adding app binary support 🙏 I tested it and dfu-util did not complain about the file extension, so, seems to work fine. The only thing that I don't find particularly appealing is the file extension .app_bin with an underscore. Maybe something like .appbin or .app-bin with a dash? Not sure if that looks any better :-) Anyway it's a small cosmetic issue. Other than that, LGTM 👍

@dpgeorge
Copy link
Member Author

seems to work fine

Great, thanks for testing.

Maybe something like .appbin or .app-bin with a dash?

I'll change it to a dash to match other parts of the filename that use dash.

@dpgeorge
tools/autobuild: Add support for application .bin files for esp32.
d14ddcb 
On esp32, the build output consists of:
- micropython.elf
- micropython.map
- micropython.bin -- application only
- micropython.uf2 -- application only
- firmware.bin -- bootloader, partition table and application

Currently everything is available at the download page except
micropython.bin.  This commit adds that file but with the extension changed
to .app-bin, to distinguish it from .bin (the full thing).

Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge dpgeorge force-pushed the tools-autobuild-support-app-bin branch from cbef59f to d14ddcb Compare July 27, 2023 03:14
@dpgeorge dpgeorge merged commit d14ddcb into micropython:master Jul 27, 2023
@dpgeorge
Copy link
Member Author

.app-bin files are now available from the download page.

@dpgeorge dpgeorge deleted the tools-autobuild-support-app-bin branch July 27, 2023 10:24
@jimmo jimmo mentioned this pull request Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tools Relates to tools/ directory in source, or other tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpgeorge @iabdalkader @sebromero
0