-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
tools/autobuild: Add support for application .bin files for esp32. #12081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools/autobuild: Add support for application .bin files for esp32. #12081
Conversation
@iabdalkader does this work for you? Due to the way the auto-build system works, it's much easier to have the name differ only by the extension (rather than, eg, |
It should be the same, CC @sebromero |
Sorry, do you mean yes it will work, or no it won't because the extension needs to be |
I mean yes it's just a binary file. I've mentioned Sebastian to confirm since he asked for the separate binary. |
Code size report:
|
Codecov Report
@@ Coverage Diff @@
## master #12081 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 157 157
Lines 20703 20703
=======================================
Hits 20368 20368
Misses 335 335 |
@dpgeorge Thanks for adding app binary support 🙏 I tested it and |
Great, thanks for testing.
I'll change it to a dash to match other parts of the filename that use dash. |
On esp32, the build output consists of: - micropython.elf - micropython.map - micropython.bin -- application only - micropython.uf2 -- application only - firmware.bin -- bootloader, partition table and application Currently everything is available at the download page except micropython.bin. This commit adds that file but with the extension changed to .app-bin, to distinguish it from .bin (the full thing). Signed-off-by: Damien George <damien@micropython.org>
cbef59f
to
d14ddcb
Compare
|
On esp32, the build output consists of:
Currently everything is available at the download page except
micropython.bin
. This commit adds that file but with the extension changed to.app_bin
, to distinguish it from.bin
(the full thing).Eg for the generic esp32 port the file would be
esp32-20230426-v1.20.0.app_bin
. For a nightly build it would beesp32-20230724-unstable-v1.20.0-312-g8ef5622b9.app_bin
.