8000 Test against JSON summaries (and bugfixes) by ConorMacBride · Pull Request #134 · matplotlib/pytest-mpl · GitHub
[go: up one dir, main page]
Skip to content

Test against JSON summaries (and bugfixes) #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Feb 9, 2022
Merged

Test against JSON summaries (and bugfixes) #134

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
35404a0
Helpers to diff JSON summary
ConorMacBride Feb 3, 2022
5f66e2e
Runner for subtests
ConorMacBride Feb 3, 2022
9f7deb0
Support for version specific patches
ConorMacBride Feb 4, 2022
2854e03
Only show match errors at end of test
ConorMacBride Feb 4, 2022
7e95ae8
Hash libraries for baseline and result
ConorMacBride Feb 4, 2022
2796fad
Add subtests
ConorMacBride Feb 4, 2022
49fcd8d
Generate baseline with full path for tox
ConorMacBride Feb 4, 2022
cd45753
Skip tests without required libraries
ConorMacBride Feb 5, 2022
f82256d
Fix bug in html without hash comparison
ConorMacBride Feb 5, 2022
ea144f7
Add subtest baselines
ConorMacBride Feb 5, 2022
7e65619
Add mpl33 to mpl35 baselines
ConorMacBride Feb 5, 2022
2d035e1
Add draft baseline summaries
ConorMacBride Feb 5, 2022
ab4bd47
Document `--mpl-baseline-relative`
ConorMacBride Feb 5, 2022
b0f62ba
Clarify behaviour
ConorMacBride Feb 5, 2022
de57cab
Update summaries for new hash and hybrid logs
ConorMacBride Feb 6, 2022
a5272a6
Update tests for new status_msg
ConorMacBride Feb 6, 2022
a2fc28b
Record image filenames during test
ConorMacBride Feb 6, 2022
188a08d
Fix bugs and refactor compare_image_to_hash_library
ConorMacBride Feb 6, 2022
e44c0c1
Update wording in log message
ConorMacBride Feb 6, 2022
03d1f76
Convert status_msg to regex
ConorMacBride Feb 6, 2022
1cb3d4e
Improved support for hash comparison only HTML summary
ConorMacBride Feb 6, 2022
33338ba
Always record image paths as POSIX
ConorMacBride Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
8000
Diff view
Prev Previous commit
Next Next commit
Fix bug in html without hash comparison
  • Loading branch information
@ConorMacBride
ConorMacBride committed Feb 5, 2022
commit f82256d81d085deedb5e0de3dc19b20b814834cf
2 changes: 2 additions & 0 deletions pytest_mpl/summary/templates/filter.html
View file
Open 8000 in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,13 @@ <h5>Show tests which have...</h5>
{{ filter_option('image-diff', 'differing images') }}
{{ filter_option('image-missing', 'no baseline image') }}
</div>
{% if results.warn_missing['baseline_hash'] -%}
<div class="list-group m-2 mpl-hash">
{{ filter_option('hash-match', 'matching hashes') }}
{{ filter_option('hash-diff', 'differing hashes') }}
{{ filter_option('hash-missing', 'no baseline hash') }}
</div>
{%- endif %}
<div class="d-flex">
<button type="submit" class="btn btn-primary m-2" data-bs-dismiss="offcanvas">Apply</button>
<button type="submit" class="btn btn-outline-secondary m-2" onclick="resetFilters()">Reset</button>
Expand Down
2 changes: 2 additions & 0 deletions pytest_mpl/summary/templates/result_images.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,15 @@ <h5 class="card-title">{{ r.name }}</h5>
{{ pre_data('toler 655F ance', r.tolerance, 'Tolerance') }}
</div>
</div>
{% if results.warn_missing['baseline_hash'] -%}
<div class="card text-white bg-{{ r.hash_status | status_class }} mb-3 mpl-hash">
<div class="card-header">{{ r.hash_status | hash_status_msg }}</div>
<div class="card-body">
{{ pre_data('baseline_hash', r.baseline_hash, 'Baseline') }}
{{ pre_data('result_hash', r.result_hash, 'Result') }}
</div>
</div>
{%- endif %}
</div>
</div>
</div>
Expand Down
0