8000 Test against JSON summaries (and bugfixes) by ConorMacBride · Pull Request #134 · matplotlib/pytest-mpl · GitHub
[go: up one dir, main page]
Skip to content

Test against JSON summaries (and bugfixes) #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Feb 9, 2022
Merged

Test against JSON summaries (and bugfixes) #134

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
35404a0
Helpers to diff JSON summary
ConorMacBride Feb 3, 2022
5f66e2e
Runner for subtests
ConorMacBride Feb 3, 2022
9f7deb0
Support for version specific patches
ConorMacBride Feb 4, 2022
2854e03
Only show match errors at end of test
ConorMacBride Feb 4, 2022
7e95ae8
Hash libraries for baseline and result
ConorMacBride Feb 4, 2022
2796fad
Add subtests
ConorMacBride Feb 4, 2022
49fcd8d
Generate baseline with full path for tox
ConorMacBride Feb 4, 2022
cd45753
Skip tests without required libraries
ConorMacBride Feb 5, 2022
f82256d
Fix bug in html without hash comparison
ConorMacBride Feb 5, 2022
ea144f7
Add subtest baselines
ConorMacBride Feb 5, 2022
7e65619
Add mpl33 to mpl35 baselines
ConorMacBride Feb 5, 2022
2d035e1
Add draft baseline summaries
ConorMacBride Feb 5, 2022
ab4bd47
Document `--mpl-baseline-relative`
ConorMacBride Feb 5, 2022
b0f62ba
Clarify behaviour
ConorMacBride Feb 5, 2022
de57cab
Update summaries for new hash and hybrid logs
ConorMacBride Feb 6, 2022
a5272a6
Update tests for new status_msg
ConorMacBride Feb 6, 2022
a2fc28b
Record image filenames during test
ConorMacBride Feb 6, 2022
188a08d
Fix bugs and refactor compare_image_to_hash_library
ConorMacBride Feb 6, 2022
e44c0c1
Update wording in log message
ConorMacBride Feb 6, 2022
03d1f76
Convert status_msg to regex
ConorMacBride Feb 6, 2022
1cb3d4e
Improved support for hash comparison only HTML summary
ConorMacBride Feb 6, 2022
33338ba
Always record image paths as POSIX
ConorMacBride Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
8000
Diff view
Prev Previous commit
Next Next commit
Update summaries for new hash and hybrid logs
  • Loading branch information
@ConorMacBride
ConorMacBride committed Feb 6, 2022
commit de57cabcc028e664f07834e219d0be93e8e702f6
16 changes: 8 additions & 8 deletions tests/subtests/summaries/test_hash.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
},
"subtests.subtest.test_hdiff_imatch": {
"status": "failed",
"status_msg": "Test hash does not match baseline hash.",
"status_msg": "Hash 6e2fdde5a6682dc6abba7121f5df702c3664b1ce09593534fc0d7c3514eb07e1 doesn't match hash d1ffdde5a6682dc6abba7121f5df702c3664b1ce09593534fc0d7c3514eb07e1 in library /Users/conor/Documents/pytest-mpl/tests/subtests/hashes/mpl34_ft261.json for test subtests.subtest.test_hdiff_imatch.",
"baseline_image": null,
"diff_image": null,
"rms": null,
Expand All @@ -45,7 +45,7 @@
},
"subtests.subtest.test_hdiff_idiff": {
"status": "failed",
"status_msg": "Test hash does not match baseline hash.",
"status_msg": "Hash 443361bdd0efd1cdd343eabf73af6f20439d4834ab5503a574ac7ec28e0c2b43 doesn't match hash d1ff61bdd0efd1cdd343eabf73af6f20439d4834ab5503a574ac7ec28e0c2b43 in library /Users/conor/Documents/pytest-mpl/tests/subtests/hashes/mpl34_ft261.json for test subtests.subtest.test_hdiff_idiff.",
"baseline_image": null,
"diff_image": null,
"rms": null,
Expand All @@ -56,7 +56,7 @@
},
"subtests.subtest.test_hdiff_imissing": {
"status": "failed",
"status_msg": "Test hash does not match baseline hash.",
"status_msg": "Hash 301e63d656d7a586cc4e498bc32b970f8cb7c7c47bbd2fec33b931219fc0690e doesn't match hash d1ff63d656d7a586cc4e498bc32b970f8cb7c7c47bbd2fec33b931219fc0690e in library /Users/conor/Documents/pytest-mpl/tests/subtests/hashes/mpl34_ft261.json for test subtests.subtest.test_hdiff_imissing.",
"baseline_image": null,
"diff_image": null,
"rms": null,
Expand Down Expand Up @@ -100,7 +100,7 @@
},
"subtests.subtest.test_hdiff_imatch_tolerance": {
"status": "failed",
"status_msg": "Test hash does not match baseline hash.",
"status_msg": "Hash aaf4e85fda98298347c274adae98ca7728f9bb2444ca8a49295145b0727b8c96 doesn't match hash d1ffe85fda98298347c274adae98ca7728f9bb2444ca8a49295145b0727b8c96 in library /Users/conor/Documents/pytest-mpl/tests/subtests/hashes/mpl34_ft261.json for test subtests.subtest.test_hdiff_imatch_tolerance.",
"baseline_image": null,
"diff_image": null,
"rms": null,
Expand All @@ -111,7 +111,7 @@
},
"subtests.subtest.test_hdiff_idiff_tolerance": {
"status": "failed",
"status_msg": "Test hash does not match baseline hash.",
"status_msg": "Hash aaf4e85fda98298347c274adae98ca7728f9bb2444ca8a49295145b0727b8c96 doesn't match hash d1ffe85fda98298347c274adae98ca7728f9bb2444ca8a49295145b0727b8c96 in library /Users/conor/Documents/pytest-mpl/tests/subtests/hashes/mpl34_ft261.json for test subtests.subtest.test_hdiff_idiff_tolerance.",
"baseline_image": null,
"diff_image": null,
"rms": null,
Expand All @@ -122,7 +122,7 @@
},
"subtests.subtest.test_hdiff_imatch_savefig": {
"status": "failed",
"status_msg": "Test hash does not match baseline hash.",
"status_msg": "Hash 5dc1c2c68c2d34c03a89ab394e3c11349b76594d0c8837374daef299ac227568 doesn't match hash d1ffc2c68c2d34c03a89ab394e3c11349b76594d0c8837374daef299ac227568 in library /Users/conor/Documents/pytest-mpl/tests/subtests/hashes/mpl34_ft261.json for test subtests.subtest.test_hdiff_imatch_savefig.",
"baseline_image": null,
"diff_image": null,
"rms": null,
Expand All @@ -133,7 +133,7 @@
},
"subtests.subtest.test_hdiff_imatch_style": {
"status": "failed",
"status_msg": "Test hash does not match baseline hash.",
"status_msg": "Hash 185ed1b702c7bbd810370b12e46ecea4b9c9eb87b743397f1d4a50177e7ba7f7 doesn't match hash d1ffd1b702c7bbd810370b12e46ecea4b9c9eb87b743397f1d4a50177e7ba7f7 in library /Users/conor/Documents/pytest-mpl/tests/subtests/hashes/mpl34_ft261.json for test subtests.subtest.test_hdiff_imatch_style.",
"baseline_image": null,
"diff_image": null,
"rms": null,
Expand All @@ -144,7 +144,7 @@
},
"subtests.subtest.test_hdiff_imatch_removetext": {
"status": "failed",
"status_msg": "Test hash does not match baseline hash.",
"status_msg": "Hash be5af83a43cb89f5e13923f532fe5c9bedbf7d13585533efef2f4051c4968b5e doesn't match hash d1fff83a43cb89f5e13923f532fe5c9bedbf7d13585533efef2f4051c4968b5e in library /Users/conor/Documents/pytest-mpl/tests/subtests/hashes/mpl34_ft261.json for test subtests.subtest.test_hdiff_imatch_removetext.",
"baseline_image": null,
"diff_image": null,
"rms": null,
Expand Down
16 changes: 8 additions & 8 deletions tests/subtests/summaries/test_html_hashes_only.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
},
"subtests.subtest.test_hdiff_imatch": {
"status": "failed",
"status_msg": "Test hash does not match baseline hash.",
"status_msg": "Hash 6e2fdde5a6682dc6abba7121f5df702c3664b1ce09593534fc0d7c3514eb07e1 doesn't match hash d1ffdde5a6682dc6abba7121f5df702c3664b1ce09593534fc0d7c3514eb07e1 in library /Users/conor/Documents/pytest-mpl/tests/subtests/hashes/mpl34_ft261.json for test subtests.subtest.test_hdiff_imatch.",
"baseline_image": null,
"diff_image": null,
"rms": null,
Expand All @@ -45,7 +45,7 @@
},
"subtests.subtest.test_hdiff_idiff": {
"status": "failed",
"status_msg": "Test hash does not match baseline hash.",
"status_msg": "Hash 443361bdd0efd1cdd343eabf73af6f20439d4834ab5503a574ac7ec28e0c2b43 doesn't match hash d1ff61bdd0efd1cdd343eabf73af6f20439d4834ab5503a574ac7ec28e0c2b43 in library /Users/conor/Documents/pytest-mpl/tests/subtests/hashes/mpl34_ft261.json for test subtests.subtest.test_hdiff_idiff.",
"baseline_image": null,
"diff_image": null,
"rms": null,
Expand All @@ -56,7 +56,7 @@
},
"subtests.subtest.test_hdiff_imissing": {
"status": "failed",
"status_msg": "Test hash does not match baseline hash.",
"status_msg": "Hash 301e63d656d7a586cc4e498bc32b970f8cb7c7c47bbd2fec33b931219fc0690e doesn't match hash d1ff63d656d7a586cc4e498bc32b970f8cb7c7c47bbd2fec33b931219fc0690e in library /Users/conor/Documents/pytest-mpl/tests/subtests/hashes/mpl34_ft261.json for test subtests.subtest.test_hdiff_imissing.",
"baseline_image": null,
"diff_image": null,
"rms": null,
Expand Down Expand Up @@ -100,7 +100,7 @@
},
"subtests.subtest.test_hdiff_imatch_tolerance": {
"status": "failed",
"status_msg": "Test hash does not match baseline hash.",
"status_msg": "Hash aaf4e85fda98298347c274adae98ca7728f9bb2444ca8a49295145b0727b8c96 doesn't match hash d1ffe85fda98298347c274adae98ca7728f9bb2444ca8a49295145b0727b8c96 in library /Users/conor/Documents/pytest-mpl/tests/subtests/hashes/mpl34_ft261.json for test subtests.subtest.test_hdiff_imatch_tolerance.",
"baseline_image": null,
"diff_image": null,
"rms": null,
Expand All @@ -111,7 +111,7 @@
},
"subtests.subtest.test_hdiff_idiff_tolerance": {
"status": "failed",
"status_msg": "Test hash does not match baseline hash.",
"status_msg": "Hash aaf4e85fda98298347c274adae98ca7728f9bb2444ca8a49295145b0727b8c96 doesn't match hash d1ffe85fda98298347c274adae98ca7728f9bb2444ca8a49295145b0727b8c96 in library /Users/conor/Documents/pytest-mpl/tests/subtests/hashes/mpl34_ft261.json for test subtests.subtest.test_hdiff_idiff_tolerance.",
"baseline_image": null,
"diff_image": null,
"rms": null,
Expand All @@ -122,7 +122,7 @@
},
"subtests.subtest.test_hdiff_imatch_savefig": {
"status": "failed",
"status_msg": "Test hash does not match baseline hash.",
"status_msg": "Hash 5dc1c2c68c2d34c03a89ab394e3c11349b76594d0c8837374daef299ac227568 doesn't match hash d1ffc2c68c2d34c03a89ab394e3c11349b76594d0c8837374daef299ac227568 in library /Users/conor/Documents/pytest-mpl/tests/subtests/hashes/mpl34_ft261.json for test subtests.subtest.test_hdiff_imatch_savefig.",
"baseline_image": null,
"diff_image": null,
"rms": null,
Expand All @@ -133,7 +133,7 @@
},
"subtests.subtest.test_hdiff_imatch_style": {
"status": "failed",
"status_msg": "Test hash does not match baseline hash.",
"status_msg": "Hash 185ed1b702c7bbd810370b12e46ecea4b9c9eb87b743397f1d4a50177e7ba7f7 doesn't match hash d1ffd1b702c7bbd810370b12e46ecea4b9c9eb87b743397f1d4a50177e7ba7f7 in library /Users/conor/Documents/pytest-mpl/tests/subtests/hashes/mpl34_ft261.json for test subtests.subtest.test_hdiff_imatch_style.",
"baseline_image": null,
"diff_image": null,
"rms": null,
Expand All @@ -144,7 +144,7 @@
},
"subtests.subtest.test_hdiff_imatch_removetext": {
"status": "failed",
"status_msg": "Test hash does not match baseline hash.",
"status_msg": "Hash be5af83a43cb89f5e13923f532fe5c9bedbf7d13585533efef2f4051c4968b5e doesn't match hash d1fff83a43cb89f5e13923f532fe5c9bedbf7d13585533efef2f4051c4968b5e in library /Users/conor/Documents/pytest-mpl/tests/subtests/hashes/mpl34_ft261.json for test subtests.subtest.test_hdiff_imatch_removetext.",
"baseline_image": null,
"diff_image": null,
"rms": null,
Expand Down
Loading
0