Remove old nose testing code #9918
Conversation
|
Not sure why I closed this... |
3ee1425 to
a305edc
Compare
|
Ah, I see it's scheduled for removal in |
f9687c0 to
96e8c49
Compare
| @@ -41,23 +41,13 @@ def _knownfailureif(fail_condition, msg=None, known_exception_class=None): | |||
| if the exception is an instance of this class. (Default = None) | |||
|
|
|||
| """ | |||
| if is_called_from_pytest(): | |||
There was a problem hiding this comment.
This function is private, so we should probably just replace its callers with the direct pytest marker call.
There was a problem hiding this comment.
technically it is public but we should still do the switch and deprecate it.
There was a problem hiding this comment.
No it isn't. The one being removed below is public, but it's already deprecated. This one is private.
There was a problem hiding this comment.
Ah, you meant is_called_from_pytest; I meant the function in which this code exists: _knownfailureif.
eab4692 to
822d395
Compare
|
Let's get this merged asap? There's a flaky test it gets rid of :) |
8fc8bdf to
b36367e
Compare
|
Great, going to wait for the rebased tests to pass and then will merge. |
Lots of old code that I guess was used when we used
nosefor testing. I've just nuked it since it was in an underscored folder, happy to deprecate instead.