Remove nose impage comparision test

dstansby · dstansby · commit a305edc9c864 · 2018-01-05T13:33:12.000Z
diff --git a/lib/matplotlib/tests/test_compare_images.py b/lib/matplotlib/tests/test_compare_images.py
@@ -132,95 +132,3 @@ def nosetest_manual_text_removal():
 
     assert len(w) == 1
     assert 'remove_text function was deprecated in version 2.1.' in str(w[0])
-
-
-@pytest.mark.parametrize(
-    'func, kwargs, errors, failures, dots',
-    [
-        (nosetest_empty, {'baseline_images': []}, [], [], ''),
-        (nosetest_empty, {'baseline_images': ['foo']},
-         [(AssertionError,
-           'Test generated 0 images but there are 1 baseline images')],
-         [],
-         'E'),
-        (nosetest_simple_figure,
-         {'baseline_images': ['basn3p02'], 'extensions': ['png'],
-          'remove_text': True},
-         [],
-         [(ImageComparisonFailure, 'Image sizes do not match expected size:')],
-         'F'),
-        (nosetest_simple_figure,
-         {'baseline_images': ['simple']},
-         [],
-         [(ImageComparisonFailure, 'images not close')] * 3,
-         'FFF'),
-        (nosetest_simple_figure,
-         {'baseline_images': ['simple'], 'remove_text': True},
-         [],
-         [],
-         '...'),
-        (nosetest_manual_text_removal,
-         {'baseline_images': ['simple']},
-         [],
-         [],
-         '...'),
-    ],
-    ids=[
-        'empty',
-        'extra baselines',
-        'incorrect shape',
-        'failing figure',
-        'passing figure',
-        'manual text removal',
-    ])
-def test_nose_image_comparison(func, kwargs, errors, failures, dots,
-                               monkeypatch):
-    nose = pytest.importorskip('nose')
-    monkeypatch.setattr('matplotlib._called_from_pytest', False)
-
-    class TestResultVerifier(nose.result.TextTestResult):
-        def __init__(self, *args, **kwargs):
-            super(TestResultVerifier, self).__init__(*args, **kwargs)
-            self.error_count = 0
-            self.failure_count = 0
-
-        def addError(self, test, err):
-            super(TestResultVerifier, self).addError(test, err)
-
-            if self.error_count < len(errors):
-                assert err[0] is errors[self.error_count][0]
-                assert errors[self.error_count][1] in str(err[1])
-            else:
-                raise err[1]
-            self.error_count += 1
-
-        def addFailure(self, test, err):
-            super(TestResultVerifier, self).addFailure(test, err)
-
-            assert self.failure_count < len(failures), err[1]
-            assert err[0] is failures[self.failure_count][0]
-            assert failures[self.failure_count][1] in str(err[1])
-            self.failure_count += 1
-
-    # Make sure that multiple extensions work, but don't require LaTeX or
-    # Inkscape to do so.
-    kwargs.setdefault('extensions', ['png', 'png', 'png'])
-
-    func = image_comparison(**kwargs)(func)
-    loader = nose.loader.TestLoader()
-    suite = loader.loadTestsFromGenerator(
-        func,
-        'matplotlib.tests.test_compare_images')
-    if six.PY2:
-        output = io.BytesIO()
-    else:
-        output = io.StringIO()
-    result = TestResultVerifier(stream=output, descriptions=True, verbosity=1)
-    with warnings.catch_warnings():
-        # Nose uses deprecated stuff; we don't care about it.
-        warnings.simplefilter('ignore', DeprecationWarning)
-        suite.run(result=result)
-
-    assert output.getvalue() == dots
-    assert result.error_count == len(errors)
-    assert result.failure_count == len(failures)
