8000 Fix scatter alpha by tacaswell · Pull Request #8954 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix scatter alpha #8954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2017
Merged

Fix scatter alpha #8954

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6994540
TST: updating alpha on collection with colormaped data
tacaswell Jul 28, 2017
2bcbe5b
FIX: mark the array data as updated to force to_rgba
tacaswell Jul 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
FIX: mark the array data as updated to force to_rgba 
closes #8953
  • Loading branch information
@tacaswell
tacaswell committed Jul 28, 2017
commit 2bcbe5b67820b59c37c67395c3973951407f63ec
1 change: 1 addition & 0 deletions lib/matplotlib/collections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,6 +711,7 @@ def set_alpha(self, alpha):
float(alpha)
except TypeError:
raise TypeError('alpha must be a float or None')
self.update_dict['array'] = True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an explanation here? I am still completely confused why this has to be here for setting alphas, but not anywhere else for any of the other colorsetting code.

Could this be the result of the collision of RGBA color specs and a separate alpha parameter?

artist.Artist.set_alpha(self, alpha)
self._set_facecolor(self._original_facecolor)
self._set_edgecolor(self._original_edgecolor)
Expand Down
0