Fix scatter alpha #8954
Merged
Fix scatter alpha #8954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
reviewed
Jul 28, 2017
| @@ -624,3 +624,14 @@ def test_lslw_bcast(): | |||
| col.set_linestyles(['-', '-', '-']) | |||
| assert_equal(col.get_linestyles(), [(None, None)] * 3) | |||
| assert_equal(col.get_linewidths(), [1, 2, 3]) | |||
|
|
|||
|
|
|||
| @image_comparison(baseline_images=['scatter_post_alpha'], | |||
There was a problem hiding this comment.
Is this a test that can just be a "check the colours haven't changed" test instead of an image test?
There was a problem hiding this comment.
I don't think so as there is some draw-time computation that goes on here with the color mapping.
WeatherGod
reviewed
Aug 10, 2017
| @@ -711,6 +711,7 @@ def set_alpha(self, alpha): | |||
| float(alpha) | |||
| except TypeError: | |||
| raise TypeError('alpha must be a float or None') | |||
| self.update_dict['array'] = True | |||
There was a problem hiding this comment.
Could you add an explanation here? I am still completely confused why this has to be here for setting alphas, but not anywhere else for any of the other colorsetting code.
Could this be the result of the collision of RGBA color specs and a separate alpha parameter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
fixes #8953
The issue is that we are re-setting the original (un-alpha-ified) color and then letting the draw re-apply the new alpha. However, if there is color-mapped data the color that gets re-set is the default (apparently). Fix this by flagging the array as updated so that
update_colormappablefires and re-set the colors properly.PR Checklist