If text location isn't finite, set it to not visible #7880
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can the issue at #6789 also be triggered by e.g. patches at nonfinite positions? It feels like the logic of ignorining nonfinite positions should go into tight_layout itself instead (having thought approximately for 5s about the issue, so I may completely wrong). |
tacaswell
reviewed
Jan 22, 2017
| @@ -1154,6 +1154,8 @@ def set_position(self, xy): | |||
| """ | |||
| self.set_x(xy[0]) | |||
| self.set_y(xy[1]) | |||
| if not np.all(np.isfinite(xy)): | |||
There was a problem hiding this comment.
This will act as a latch and this text will awlays be invisible
|
I guess you could have a scale that brings infinity to a finite value? :-) (although that would probably crash other parts of mpl) |
4 tasks
|
Closing this, since the eventual fix will be different. If anyone else wants to pick this up feel free. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #6789. The problem was there was some text at +/- inf locations, which mean that when the
tight_layoutcalculation was being done aninfwas being passed through.I think it's reasonable to set text with co-ordinates that aren't finite to not visible as I presume it'll never be seen, although this currently just hides the problem without a warning or error. Perhaps this should raise a warning or error too? Thoughts appreciated!