8000 Added images and links for seaborn, holoviews, and ggplot by jbednar · Pull Request #6106 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Added images and links for seaborn, holoviews, and ggplot #6106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2016
Merged

Added images and links for seaborn, holoviews, and ggplot #6106

merged 1 commit into from
Mar 3, 2016

Conversation

jbednar
Copy link
Contributor
@jbednar jbednar commented Mar 3, 2016

As suggested in #6088, partially backported changes from #6088 to the v1.5.1-doc branch so that they will go public prior to the v2.0 release.

=========
(*Not distributed with matplotlib*)

`holoviews <http://holoviews.org>`_ makes it easier to visualize data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seem to recall @tacaswell saying something about these links requiring two _ at the end.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single _ is the simplest link. but if you tried to use the word 'holoviews' for a different link elsewhere on the same page sphinx would complain as it was now confused where 'holoviews' should point. Using __ makes it an 'anonymous' link so you can re-use the same text with a different target elsewhere on the page. (as explained by @jenshnielsen )

@QuLogic QuLogic added this to the 1.5.2 (Critical bug fix release) milestone Mar 3, 2016
tacaswell added a commit that referenced this pull request Mar 3, 2016
Added images and links for seaborn, holoviews, and ggplot
@tacaswell tacaswell merged commit 76bf550 into matplotlib:v1.5.1-doc Mar 3, 2016
@tacaswell
Copy link
Member

I tried to do the merge cascade, but v2.x does not cleanly merge into master. I will come back to this tomorrow.

@jbednar jbednar deleted the v1.5.1-doc branch March 4, 2016 14:32
@tacaswell
Copy link
Member

@jbednar Took me almost 2 months 🐑, but I finally rebuilt the docs. This version should be live now.

@jbednar
Copy link
Contributor Author
jbednar commented May 2, 2016

Looks great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0