8000 Third party docs fixes/updates by jbednar · Pull Request #6088 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Third party docs fixes/updates #6088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 39 commits into from
Closed

Third party docs fixes/updates #6088

wants to merge 39 commits into from

Conversation

jbednar
Copy link
Contributor
@jbednar jbednar commented Mar 1, 2016

The link in master from the homepage to the "Third party packages" page was broken, because it was still directing people to mpl_toolkits, even though the contents have moved to thirdpartypackages/. The organization of the third party packages page itself was also hard to follow, because it listed several smaller and miscellaneous packages before substantial packages like seaborn.

Reorganized to first discuss large projects providing alternative APIs for matplotlib, including the new HoloViews package, then large geographic plotting packages, and then the remaining smaller packages (which seem difficult to categorize into meaningful groups). Also added images for seaborn and ggplot, so that people have a better idea of what they offer, and to make the page be more balanced visually.

The resulting web pages seem to build ok; e.g.:

http://homepages.inf.ed.ac.uk/jbednar/mpl/thirdpartypackages/index.html

http://homepages.inf.ed.ac.uk/jbednar/mpl/index.html

I've applied this pull request to the master, because it is meant to update the most current copy of the web site, but let me know if a change to the docs like this should have been against another branch.

@mdboom mdboom added this to the 1.5.2 (Critical bug fix release) milestone Mar 1, 2016
@mdboom
Copy link
Member
mdboom commented Mar 1, 2016

👍 I'd be in favor of merging this to 1.5.x-docs, just so it gets deployed sooner, but there's nothing for you to do -- we can backport.

@tacaswell
Copy link
Member

I am a bit concerned that our link-checker did not find the broken link.

Cartopy
=======

An alternative mapping library written for matplotlib ``v1.2`` and beyond.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, can you change this to 1.3? The next release will drop support for 1.2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just deleted that line altogether. I don't think matplotlib's website needs to keep track of that information; people can find out about supported versions from cartopy's website, which cartopy's maintainers keep up to date...

@jenshnielsen
Copy link
Member

@tacaswell The link is not broken It is just wrong (my mistake when I moved al of this around)

@jenshnielsen
Copy link
Member

@mdboom This will not backport directly since my doc changes splitting these are not backported as is

@jbednar
Copy link
Contributor Author
jbednar commented Mar 2, 2016

Sorry to be ambiguous -- yes, the link was not really broken, just out of date. It was pointing to a real page, just not the correct one.

I'd be happy to make a similar (but incompatible due to the page splitting) pull request for the 1.5.x-docs branch; just let me know.

@tacaswell
Copy link
Member

@jbednar That would be great, thanks.

@jbednar
Copy link
Contributor Author
jbednar commented Mar 3, 2016

Ok, I pulled out the novel content and put it into a separate PR for the docs branch (#6106). I didn't attempt to re-do the reorganization that @jenshnielsen did; I just added the new bits in the locations they already were.

@tacaswell
Copy link
Member

I have merged #6106 and when will do the merge cascade + doc rebuild later tonight. This PR will likely require a rebase after that.

@tacaswell
Copy link
Member

@jbednar This needs to be re-based.

crazyo and others added 22 commits March 7, 2016 22:41
_apply_params was calling setattr on _size and _color instead of _labelsize and _labelcolor
test will make two calls two set_tick_params.  After the fix the second call should not change any of the ticks color or size values.
The second call to set_tick_params would mess the padding up only after the first call was causing size and color to be set incorrectly.  Thus the test is changed to ensure the root cause is fixed and not the propagation of it
The removal of the module level 'backend' broke ipython's pylab code.
This is the first attempt to bring it back.
fixed a word
Alternative to #6070

This works by converting the greyscale image to an RGBA image (with the
alpha channel created correctly) prior to resizing in Agg.  This also
removes the hack (that caused problems with over/under) where we were
using negative values to indicate transparency.
suggest installing pkg-config if freetype is not found
clarifies that these instructions can be used when installing matplotlib for Python installed with Homebrew/Macports
Arrays of non-uint8 types were assumed to be in 0..1 range.

When this was not true and integer values were used, only the low-order
bits were used, resulting in a mangled image. Now, an explicit exception
is raised.

Closes issue #2499
QMessageBox is in QtWidgets, not QtGui.
@jbednar
Copy link
Contributor Author
jbednar commented Mar 8, 2016

I rebased, but it looks like a mess now. I presume I should just checkout master again and replay my original changes for a new PR?

@tacaswell
Copy link
Member

Or just force-push that new branch to this PR.

It looks like you did the rebase backwards (master onto your branch, not your branch onto master)?

@jbednar
Copy link
Contributor Author
jbednar commented Mar 9, 2016

I didn't want to try to figure out those particular git mysteries, so I just built a new PR. :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0