Add dtype/copy args to internal testing class #27862
Conversation
|
I do believe the immediate need for this has been taken care of upstream (numpy/numpy#25922) but this is still likely good for future proofing... However, I think there is a chance it needs to be a touch more complicated than this to avoid sending the We do not have the nightly test set up to run on e.g. a label like some other tests. (And in fact can't even run it off schedule at all... it is actually just the normal tests workflow that adds the nightly repo and |
|
I'm not 100% sure I've implemented this in the best way - for a small internal testing class I think it's probably fine though? |
|
Maybe leave ourselves a comment that once we drop numpy 1.x support this can just be |
PR summary
This fixes some test failures in #27844 that we're responsible for. I'm guessing the new requirement on copy/dtype args is from numpy 2.0. I'm not sure if there's a way to run the weekly CI on a PR to check this fixes the issue?
PR checklist