8000 [TST] Upcoming dependency test failures · Issue #27844 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

[TST] Upcoming dependency test failures #27844

New issue

Have a question about this project? Sign up fo 8000 r a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
github-actions bot opened this issue Mar 2, 2024 · 3 comments
Closed

[TST] Upcoming dependency test failures #27844

github-actions bot opened this issue Mar 2, 2024 · 3 comments
Labels
third-party integration: pandas

Comments

@github-actions
Copy link
github-actions bot commented Mar 2, 2024

The weekly build with nightly wheels from numpy and pandas
has failed. Check the logs for any updates that need to be
made in matplotlib.
https://github.com/matplotlib/matplotlib/actions/runs/8120774021
@ksunden
Copy link
Member
ksunden commented Mar 4, 2024

I think this is related to numpy/numpy#25168

I believe the direct problems are now sorted upstream by numpy/numpy#25922 (though the likes of pandas and our internal test structures may still need to grow a copy arg for future proofing)

This may also to be tangentially related to Pandas and their efforts to move to Copy on Write (CoW) semantics, removing the "copy" kwarg in some instances (though I think those were largely at least intended to undergo deprecation).

@ngoldbaum can you confirm?

@dstansby dstansby mentioned this issue Mar 4, 2024
Merged
5 tasks
@ngoldbaum
Copy link
Contributor

That’s right, the initial version of those changes were broken (sorry!) and should be fixed now.

Any array-like in matplotlib and elsewhere impl 825E ementing the __array__ protocol needs to grow a copy keyword argument. Also any places with np.array(…, copy=False) that lead to an error about not being able to do the operation without a copy, you likely want np.asarray instead. The old behavior of copy=False wasn’t really “never copy” it was more like “only copy if needed” which is the default semantics for asarray.

@ksunden
Copy link
Member
ksunden commented May 8, 2024

Sorted out upstream

@ksunden ksunden closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
third-party integration: pandas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ksunden @ngoldbaum @dstansby
0