use RectangleSelector for callbacks and use getter functions for axes #26166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the same pull request to #26107 which was closed by mistake |
ksunden
reviewed
Jun 23, 2023
Comment on lines
+54
to
+59
| x0, x1 = ax.get_xlim() | ||
| y0, y1 = ax.get_ylim() | ||
| extent = x0, x1, y0, y1 | ||
| x0, x1 = ax.get_xlim() | ||
| y0, y1 = ax.get_ylim() | ||
| extent = x0, x1, y0, y1 |
There was a problem hiding this comment.
Suggested change
| x0, x1 = ax.get_xlim() | |
| y0, y1 = ax.get_ylim() | |
| extent = x0, x1, y0, y1 | |
| x0, x1 = ax.get_xlim() | |
| y0, y1 = ax.get_ylim() | |
| extent = x0, x1, y0, y1 | |
| x0, x1 = ax.get_xlim() | |
| y0, y1 = ax.get_ylim() | |
| extent = x0, x1, y0, y1 |
QuLogic
reviewed
Jun 24, 2023
| @@ -3,7 +3,7 @@ | |||
| Viewlims | |||
| ======== | |||
|
|
|||
| Creates two identical panels. Zooming in on the right panel will show | |||
| Creates two identical panels. Zooming in on the left panel will show | |||
There was a problem hiding this comment.
I'm not sure why this changed; the rectangle is still on the left, and zooming occurs on the right.
Comment on lines
24
to
27
| # the area to which we are zoomed. | ||
|
|
||
|
|
||
| class MandelbrotDisplay: |
There was a problem hiding this comment.
Revert
Suggested change
| # the area to which we are zoomed. | |
| class MandelbrotDisplay: | |
| # the area to which we are zoomed. | |
| class MandelbrotDisplay: |
|
|
||
| ax1.set_title("Zoom here") |
There was a problem hiding this comment.
Why did this change Axes to the left one?
That is, if you mean to say, "use the rectangle selector", then maybe rename to "Select here" instead.
Comment on lines
-85
to
-87
| # Connect for changing the view limits | ||
| ax2.callbacks.connect('xlim_changed', rect) | ||
| ax2.callbacks.connect('ylim_changed', rect) |
There was a problem hiding this comment.
Ah, I see this part is missing, namely that zooming on the right Axes updates the selector on the left.
|
Hi @francis-wong are you still interested in working on this? |
|
Superseeded by #27594 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
PR checklist