8000 Use RectangleSelector for callbacks and getter functions for axes by francis-wong · Pull Request #26107 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Use RectangleSelector for callbacks and getter functions for axes #26107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use RectangleSelector for callbacks and getter functions for axes #26107

wants to merge 1 commit into from

Conversation

francis-wong
Copy link

PR summary

  • Closes [Doc]: Cleanup viewlims example #25979
  • Uses RectangleSelector callbacks to redraw images instead of subclassing Rectangle to make it callable
  • Change accessing ax.xlim and ax.ylim properties directly to using ax.get_xlim() and ax.get_ylim() getter functions

PR checklist

github-actions[bot]
github-actions bot reviewed Jun 11, 2023
View reviewed changes
Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

QuLogic
QuLogic reviewed Jun 16, 2023
View reviewed changes
8000
@francis-wong francis-wong deleted the issue-25979 branch June 22, 2023 05:58
@QuLogic
Copy link
Member
QuLogic commented Jun 22, 2023

@francis-wong did you mean to close this PR?

@francis-wong
Copy link
Author

sorry I think I've closed it by mistake, was trying to submit another pull request on this branch.

@francis-wong francis-wong mentioned this pull request Jun 22, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
Documentation
Projects
First Time Contributors
Status: Waiting for author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Doc]: Cleanup viewlims example
3 participants
@francis-wong @QuLogic @melissawm
0