8000 Expire QuadMesh old signature deprecation by oscargus · Pull Request #24356 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Expire QuadMesh old signature deprecation #24356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2022
Merged

Expire QuadMesh old signature deprecation #24356

merged 1 commit into from
Nov 4, 2022

Conversation

oscargus
Copy link
Member
@oscargus oscargus commented Nov 3, 2022 •
edited
Loading

PR Summary

Tests crash locally (they sometimes do), so will run the tests here and then add a release note.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@oscargus oscargus force-pushed the quadmeshsignatureremoval branch from 8dc35d2 to 8407301 Compare November 3, 2022 21:49
oscargus
oscargus commented Nov 3, 2022
View reviewed changes
lib/matplotlib/collections.py
raise ValueError(
f"For X ({width}) and Y ({height}) with {self._shading} "
f"shading, the expected shape of A is ({h}, {w}), not "
f"{A.shape}")

if faulty_data:
raise TypeError(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that this should be a ValueError?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@oscargus oscargus force-pushed the quadmeshsignatureremoval branch from 8407301 to 091c7ce Compare November 3, 2022 21:53
@oscargus oscargus marked this pull request as ready for review November 3, 2022 21:57
@oscargus oscargus added this to the v3.7.0 milestone Nov 3, 2022
@ksunden ksunden merged commit 61c67e4 into matplotlib:main Nov 4, 2022
@oscargus oscargus deleted the quadmeshsignatureremoval branch November 5, 2022 23:17
@anntzer anntzer mentioned this pull request Dec 28, 2022
Merged
6 tasks
@QuLogic QuLogic mentioned this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@ksunden ksunden ksunden approved these changes

Assignees
No one assigned
Labels
API: changes topic: collections and mappables
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oscargus @ksunden @timhoffm
0