10000 Simplify shape-checking in QuadMesh.set_array. by anntzer · Pull Request #24829 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Simplify shape-checking in QuadMesh.set_array. #24829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Dec 28, 2022

This can be done now that the previously existing allowance for A having the wrong shape but right number of elements has been removed.

Also, raising ValueError in all cases is more consistent (#24356 (comment)).

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

This can be done now that the previously existing allowance for `A`
having the wrong shape but right number of elements has been removed.

Also, raising ValueError in all cases is more consistent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0