8000 Simplify shape-checking in QuadMesh.set_array. by anntzer · Pull Request #24829 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Simplify shape-checking in QuadMesh.set_array. #24829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2022
Merged

Simplify shape-checking in QuadMesh.set_array. #24829

merged 1 commit into from
Dec 29, 2022
+31 −51

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Dec 28, 2022

This can be done now that the previously existing allowance for A having the wrong shape but right number of elements has been removed.

Also, raising ValueError in all cases is more consistent (#24356 (comment)).

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@anntzer
Simplify shape-checking in QuadMesh.set_array.
6286b93 
This can be done now that the previously existing allowance for `A`
having the wrong shape but right number of elements has been removed.

Also, raising ValueError in all cases is more consistent.
@QuLogic QuLogic added this to the v3.7.0 milestone Dec 29, 2022
@QuLogic QuLogic merged commit d27ecc1 into matplotlib:main Dec 29, 2022
@anntzer anntzer deleted the qms branch December 29, 2022 07:55
@QuLogic QuLogic mentioned this pull request Jan 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@oscargus oscargus oscargus approved these changes

4FA5 Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @oscargus
0