Backport PR #22283: Fixed repr for SecondaryAxis
#22325
Conversation
repr for `SecondaryAxisrepr for SecondaryAxis
ccd0f1b to
44a4c52
Compare
|
The 3.5.x branch will get merged up every so often, typically right after we do a release so that Cherry-picking back any tests adding with the change is the right thing to do so we are sure that the backport also actually fixes the bug. Because we do not backport everything it is possible that the fix on the main branch implicitly relies on some other non-backported change to function properly. |
Yes, indeed the test for the change. Here I also added a bunch of other tests to get coverage up, so those were the ones I primarily referred to. But no harm adding those anyway. |
|
Oh, I understand now. Backporting all of the tests you added in that PR is the right thing to do 👍🏻 |
PR Summary
Manual cherry-picking as the original attempt to back-port had conflicts.
(I included all the additional tests as well as I am not sure if you merge 3.5.x and main at some stage or not and no harm having them there anyway,)
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).