-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fixed repr
for SecondaryAxis
#22283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed repr
for SecondaryAxis
#22283
Conversation
and increase coverage for axes/_base.py
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>< 8000 /div>
@meeseeksdev backport to v3.5.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
OK, I won't bother then. |
Should I backport manually? No problems. Most likely it is a conflict in the tests, so should be easy to fix. |
@oscargus If you want to do the backport we will definitely merge it. |
…v3.5.x Backport PR #22283: Fixed `repr` for `SecondaryAxis`
and increase coverage for axes/_base.py
PR Summary
Main purpuse was to increase test coverage, but when I played around, I found the following:
so I fixed that as well.
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).