8000 Jointly track x and y in PolygonSelector. by anntzer · Pull Request #21894 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Jointly track x and y in PolygonSelector. #21894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2022
Merged

Jointly track x and y in PolygonSelector. #21894

merged 1 commit into from
Jan 12, 2022

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Dec 9, 2021

It's easier to track them in a single list.

Also init _selection_artist and _polygon_handles with empty arrays, as
there's no reason to pretend that they start with 0, 0. On the other
hand, _xys does need to start as a non-empty array as the last point
gets updated as being the cursor position.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@dstansby
Copy link
Member
dstansby commented Dec 9, 2021

Can we wait until #21830 is merged for this to go in?

@anntzer
Copy link
Contributor Author
anntzer commented Dec 9, 2021

Sure, sorry, I had only noticed #21881 as potentially conficting.

@anntzer anntzer marked this pull request as draft December 9, 2021 19:40
@ericpre
Copy link
Member
ericpre commented Jan 9, 2022

#21830 has been merged, @anntzer, can you please rebase this PR?

@anntzer anntzer force-pushed the polygonselectorxy branch from 6c146b9 to 89d09c4 Compare January 9, 2022 17:21
@anntzer
Copy link
Contributor Author
anntzer commented Jan 9, 2022

Thanks for the notification, rebased.

@anntzer anntzer marked this pull request as ready for review January 9, 2022 17:21
@QuLogic
Copy link
Member
QuLogic commented Jan 12, 2022

Seems to have broken some things.

@anntzer
Copy link
Contributor Author
anntzer commented Jan 12, 2022

Thanks, I missed a point when rebasing over #21830.

dstansby
dstansby approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member
@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer, thanks a lot! This approval is contingent on CI passing.

@anntzer
Jointly track x and y in PolygonSelector.
7f4eb87 
It's easier to track them in a single list.

Also init _selection_artist and _polygon_handles with empty arrays, as
there's no reason to pretend that they start with 0, 0.  On the other
hand, _xys does need to start as a non-empty array as the last point
gets updated as being the cursor position.
timhoffm
timhoffm reviewed Jan 12, 2022
View reviewed changes
@timhoffm timhoffm added this to the v3.6.0 milestone Jan 12, 2022
@timhoffm timhoffm merged commit 51f10e2 into matplotlib:main Jan 12, 2022
@anntzer anntzer deleted the polygonselectorxy branch January 12, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Maintenance topic: widgets/UI
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@anntzer @dstansby @ericpre @QuLogic @timhoffm
0