8000 Add a PolygonSelector.verts setter by dstansby · Pull Request #21881 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Add a PolygonSelector.verts setter #21881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2021
Merged

Add a PolygonSelector.verts setter #21881

merged 1 commit into from
Dec 9, 2021

Conversation

dstansby
Copy link
Member
@dstansby dstansby commented Dec 8, 2021 •
edited
Loading

PR Summary

This allows one to set up a PolygonSelector programmatically without having to click, and is similar to already-implemented functionality in RectangleSelector.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

8000
@dstansby dstansby marked this pull request as draft December 8, 2021 14:51
@dstansby dstansby added this to the v3.6.0 milestone Dec 8, 2021
@dstansby dstansby marked this pull request as ready for review December 8, 2021 18:38
ericpre
ericpre approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member
@ericpre ericpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, maybe add an example to the docstring?

anntzer
anntzer approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor
@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the docstring example can come as a separate PR.

@anntzer anntzer merged commit 21b76ae into matplotlib:main Dec 9, 2021
@dstansby dstansby deleted the verts-setter branch December 9, 2021 17:59
@anntzer anntzer mentioned this pull request Dec 9, 2021
Merged
6 tasks
@ericpre ericpre mentioned this pull request Jan 9, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@ericpre ericpre ericpre approved these changes

Assignees
No one assigned
Labels
topic: widgets/UI
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dstansby @anntzer @ericpre
0