8000 Remove some boilerplate from C extension inits. by anntzer · Pull Request #20872 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Remove some boilerplate from C extension inits. #20872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions src/_backend_agg_wrapper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -638,17 +638,7 @@ static PyTypeObject *PyRendererAgg_init_type(PyObject *m, PyTypeObject *type)
return type;
}

static struct PyModuleDef moduledef = {
PyModuleDef_HEAD_INIT,
"_backend_agg",
NULL,
0,
NULL,
NULL,
NULL,
NULL,
NULL
};
static struct PyModuleDef moduledef = { PyModuleDef_HEAD_INIT, "_backend_agg" };

#pragma GCC visibility push(default)

Expand Down
3 changes: 2 additions & 1 deletion src/_c_internal_utils.c
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,8 @@ static PyMethodDef functions[] = {
"On non-Windows platforms, does nothing."},
{NULL, NULL}}; // sentinel.
static PyModuleDef util_module = {
PyModuleDef_HEAD_INIT, "_c_internal_utils", "", 0, functions, NULL, NULL, NULL, NULL};
PyModuleDef_HEAD_INIT, "_c_internal_utils", NULL, 0, functions
};

#pragma GCC visibility push(default)
PyMODINIT_FUNC PyInit__c_internal_utils(void)
Expand Down
12 changes: 1 addition & 11 deletions src/_contour_wrapper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -152,17 +152,7 @@ static PyTypeObject* PyQuadContourGenerator_init_type(PyObject* m, PyTypeObject*

/* Module */

static struct PyModuleDef moduledef = {
PyModuleDef_HEAD_INIT,
"_contour",
NULL,
0,
NULL,
NULL,
NULL,
NULL,
NULL
};
static struct PyModuleDef moduledef = { PyModuleDef_HEAD_INIT, "_contour" };

#pragma GCC visibility push(default)

Expand Down
10 changes: 1 addition & 9 deletions src/_image_wrapper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -295,15 +295,7 @@ static PyMethodDef module_functions[] = {
};

static struct PyModuleDef moduledef = {
PyModuleDef_HEAD_INIT,
"_image",
NULL,
0,
module_functions,
NULL,
NULL,
NULL,
NULL
PyModuleDef_HEAD_INIT, "_image", NULL, 0, module_functions,
};

#pragma GCC visibility push(default)
Expand Down
10 changes: 1 addition & 9 deletions src/_macosx.m
Original file line number Diff line number Diff line change
Expand Up @@ -2295,15 +2295,7 @@ static void context_cleanup(const void* info)
};

static struct PyModuleDef moduledef = {
PyModuleDef_HEAD_INIT,
"_macosx",
"Mac OS X native backend",
-1,
methods,
NULL,
NULL,
NULL,
NULL
PyModuleDef_HEAD_INIT, "_macosx", "Mac OS X native backend", -1, methods
};

#pragma GCC visibility push(default)
Expand Down
21 changes: 2 additions & 19 deletions src/_path_wrapper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -892,32 +892,15 @@ static PyMethodDef module_functions[] = {
};

static struct PyModuleDef moduledef = {
PyModuleDef_HEAD_INIT,
"_path",
NULL,
0,
module_functions,
NULL,
NULL,
NULL,
NULL
PyModuleDef_HEAD_INIT, "_path", NULL, 0, module_functions
};

#pragma GCC visibility push(default)

PyMODINIT_FUNC PyInit__path(void)
{
PyObject *m;

import_array();

m = PyModule_Create(&moduledef);

if (m == NULL) {
return NULL;
}

return m;
return PyModule_Create(&moduledef);
}

#pragma GCC visibility pop
2 changes: 1 addition & 1 deletion src/_tkagg.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ void load_tkinter_funcs(void)
#endif // end not Windows

static PyModuleDef _tkagg_module = {
PyModuleDef_HEAD_INIT, "_tkagg", "", -1, functions, NULL, NULL, NULL, NULL
PyModuleDef_HEAD_INIT, "_tkagg", NULL, -1, functions
};

#pragma GCC visibility push(default)
Expand Down
7 changes: 1 addition & 6 deletions src/_ttconv.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -184,19 +184,14 @@ static PyModuleDef ttconv_module = {
module_docstring,
-1,
ttconv_methods,
NULL, NULL, NULL, NULL
};

#pragma GCC visibility push(default)

PyMODINIT_FUNC
PyInit__ttconv(void)
{
PyObject* m;

m = PyModule_Create(&ttconv_module);

return m;
return PyModule_Create(&ttconv_module);
}

#pragma GCC visibility pop
12 changes: 1 addition & 11 deletions src/ft2font_wrapper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1533,17 +1533,7 @@ static PyTypeObject *PyFT2Font_init_type(PyObject *m, PyTypeObject *type)
return type;
}

static struct PyModuleDef moduledef = {
PyModuleDef_HEAD_INIT,
"ft2font",
NULL,
0,
NULL,
NULL,
NULL,
NULL,
NULL
};
static struct PyModuleDef moduledef = { PyModuleDef_HEAD_INIT, "ft2font" };

#pragma GCC visibility push(default)

Expand Down
17 changes: 2 additions & 15 deletions src/qhull_wrap.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -308,29 +308,16 @@ static PyMethodDef qhull_methods[] = {

static struct PyModuleDef qhull_module = {
PyModuleDef_HEAD_INIT,
"qhull",
"Computing Delaunay triangulations.\n",
-1,
qhull_methods,
NULL, NULL, NULL, NULL
"qhull", "Computing Delaunay triangulations.\n", -1, qhull_methods
};

#pragma GCC visibility push(default)

PyMODINIT_FUNC
PyInit__qhull(void)
{
PyObject* m;

import_array();

m = PyModule_Create(&qhull_module);

if (m == NULL) {
return NULL;
}

return m;
return PyModule_Create(&qhull_module);
}

#pragma GCC visibility pop
15 changes: 1 addition & 14 deletions src/tri/_tri_wrapper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -489,20 +489,7 @@ static PyTypeObject* PyTrapezoidMapTriFinder_init_type(PyObject* m, PyTypeObject
return type;
}


/* Module */

static struct PyModuleDef moduledef = {
PyModuleDef_HEAD_INIT,
"_tri",
NULL,
0,
NULL,
NULL,
NULL,
NULL,
NULL
};
static struct PyModuleDef moduledef = { PyModuleDef_HEAD_INIT, "_tri" };

#pragma GCC visibility push(default)

Expand Down
0