Remove some boilerplate from C extension inits. #20872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Trailing NULL fields in PyModuleDefs can be left unfilled (they will be filled with NULLs both in C and in C++, and this is also what https://docs.python.org/3/extending/extending.html#a-simple-example does). - Empty docstrings should be set to NULL (None), not "". - If no postprocessing is done, the return value of PyModule_Create can be returned directly without checking for NULL (NULL will just pass-though).
jkseppan
approved these changes
Aug 21, 2021
tacaswell
approved these changes
Aug 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
be filled with NULLs both in C and in C++, and this is also what
https://docs.python.org/3/extending/extending.html#a-simple-example
does).
be returned directly without checking for NULL (NULL will just
pass-though).
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).