Move setup.cfg to mplsetup.cfg. #20871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... in order to avoid having to jump through hoops to work around the fact that distutils/setuptools also intend to use setup.cfg just for themselves.
timhoffm
approved these changes
Aug 21, 2021
jkseppan
approved these changes
Aug 21, 2021
tacaswell
added a commit
to tacaswell/matplotlib-feedstock
that referenced
this pull request
Aug 21, 2021
In mpl3.5 the name of the file Matplotlib looks for by default will change from config.cfg to mplconfig.cfc (to not conflict with setuptools/distutils see matplotlib/matplotlib#20871 ). This uses the MPLSETUPCFG env (which exist from 0.x days) to set the path which will work for all existing and expected versions of Matplotlib.
|
attn @QuLogic @sandrotosi @felixonmars @dopplershift as I think this will require changes to packaging (I just opened a PR for conda-forge). |
5 tasks
tacaswell
added a commit
to tacaswell/matplotlib-feedstock
that referenced
this pull request
Aug 24, 2021
In mpl3.5 the name of the file Matplotlib looks for by default will change from config.cfg to mplconfig.cfc (to not conflict with setuptools/distutils see matplotlib/matplotlib#20871 ). This uses the MPLSETUPCFG env (which exist from 0.x days) to set the path which will work for all existing and expected versions of Matplotlib.
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
Nov 22, 2021
Done in matplotlib#20871 as part of de-conflicting our config files from other tools.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... in order to avoid having to jump through hoops to work around the
fact that distutils/setuptools also intend to use setup.cfg just for
themselves.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).