8000 MNT: change how mplconfig.cfg is passed in by tacaswell · Pull Request #301 · conda-forge/matplotlib-feedstock · GitHub
[go: up one dir, main page]
Skip to content

MNT: change how mplconfig.cfg is passed in #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2021
Merged

MNT: change how mplconfig.cfg is passed in #301

merged 1 commit into from
Aug 25, 2021

Conversation

tacaswell
Copy link
Contributor
@tacaswell tacaswell commented Aug 21, 2021 •
edited
Loading

In mpl3.5 the name of the file Matplotlib looks for by default will change from
config.cfg to mplconfig.cfc (to not conflict with setuptools/distutils see
matplotlib/matplotlib#20871 ).

This uses the MPLSETUPCFG env (which exist from 0.x days) to set the path which
will work for all existing and expected versions of Matplotlib.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@tacaswell
Copy link
Contributor Author

Not sure if it worth actually re-building with this change (as it should not change anything about the produced artifact), but we should get the change in the repo ahead of 3.5. Is there a way to land changes on the default branch without triggering the full release process?

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@dopplershift
Copy link
Member
dopplershift commented Aug 24, 2021 8000

I think it'd be fine to add this commit to the PR that updates to 3.5. What about build_base.bat?

@tacaswell
MNT: change how mplconfig.cfg is passed in
847ead8 
In mpl3.5 the name of the file Matplotlib looks for by default will change from
config.cfg to mplconfig.cfc (to not conflict with setuptools/distutils see
matplotlib/matplotlib#20871 ).

This uses the MPLSETUPCFG env (which exist from 0.x days) to set the path which
will work for all existing and expected versions of Matplotlib.
@tacaswell
Copy link
Contributor Author

Good point, I forgot about windows. I went with aggressive pattern matching, lets see how that goes.

This is done in a back-compatible way so I'm slightly inclined to get this in ahead (but saying that is the degree to which I am willing to push for it!).

@dopplershift dopplershift merged commit 84d3d4d into conda-forge:master Aug 25, 2021
@dopplershift
Copy link
Member

I went ahead and merged it because I want to get builds for 3.5.0b1 up.

@tacaswell tacaswell deleted the mpl35_prep branch August 25, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift Awaiting requested review from dopplershift

@mdboom mdboom Awaiting requested review from mdboom

@ocefpaf ocefpaf Awaiting requested review from ocefpaf

@pelson pelson Awaiting requested review from pelson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tacaswell @conda-forge-linter @dopplershift
0