8000 Cleanup installing docs by timhoffm · Pull Request #19725 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Cleanup installing docs #19725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2021
Merged

Cleanup installing docs #19725

merged 1 commit into from
Mar 20, 2021

Conversation

timhoffm
Copy link
Member
@timhoffm timhoffm commented Mar 17, 2021 •
edited
Loading

PR Summary

  • Move "Installing from source" contents to it's own page to declutter the main installing page.
    The Installation FAQ should be merged in to the new "Installing from source" page, but that's for a separate PR.
  • Rewording.

Adresses part of #17327. Still to do is merging the Installation FAQ (see above).

jklymak
jklymak reviewed Mar 18, 2021
View reviewed changes
Copy link
Member
@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small suggestions, but overall seems great...

anntzer
anntzer reviewed Mar 19, 2021
View reviewed changes
anntzer
anntzer reviewed Mar 19, 2021
View reviewed changes
anntzer
anntzer reviewed Mar 19, 2021
View reviewed changes
anntzer
anntzer reviewed Mar 19, 2021
View reviewed changes
anntzer
anntzer approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor
@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, but nothing blocking.

@timhoffm timhoffm added this to the v3.4-doc milestone Mar 20, 2021
@timhoffm
Copy link
Member Author

Self-merging based on @anntzer's approval.

@timhoffm timhoffm merged commit 91cb8a8 into matplotlib:master Mar 20, 2021
@timhoffm timhoffm deleted the doc-installing branch March 20, 2021 01:26
@jklymak jklymak mentioned this pull request Mar 22, 2021
Merged
7 tasks
@QuLogic
Copy link
Member
QuLogic commented Mar 26, 2021

@meeseeksdev backport to v3.4.0-doc

@meeseeksmachine meeseeksmachine mentioned this pull request Mar 26, 2021
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 26, 2021
@timhoffm @meeseeksmachine
Backport PR matplotlib#19725: Cleanup installing docs
8460dad
QuLogic pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 26, 2021
@timhoffm @jklymak
@tacaswell @QuLogic
Backport PR matplotlib#19725/matplotlib#19758: Cleanup installing docs
1215060 
Co-authored-by: Jody Klymak <jklymak@gmail.com>
Co-authored-by: Thomas A Caswell <tcaswell@gmail.com>
QuLogic added a commit that referenced this pull request Mar 26, 2021
@QuLogic
Merge pull request #19781 from meeseeksmachine/auto-backport-of-pr-19…
e4808b9 
…725-on-v3.4.0-doc

Backport PR #19725/#19758 on branch v3.4.0-doc (Cleanup installing docs)
@SauravMaheshkar SauravMaheshkar mentioned this pull request Jan 4, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak left review comments

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.4-doc
Development

Successfully merging this pull request may close these issues.
4 participants
@timhoffm @QuLogic @anntzer @jklymak
0