8000 Don't duplicate deprecated parameter addendum. by QuLogic · Pull Request #17814 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Don't duplicate deprecated parameter addendum. #17814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2020
Merged

Don't duplicate deprecated parameter addendum. #17814

merged 1 commit into from
Jul 1, 2020

Conversation

QuLogic
Copy link
Member
@QuLogic QuLogic commented Jul 1, 2020

PR Summary

Since kwargs is from the outer scope, adding to it will persist for every time the deprecated wrapper function is called. Instead, save the original addendum in the outer scope, and don't modify the outer variables in the inner wrapper function.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@QuLogic
Don't duplicate deprecated parameter addendum.
9b15aaf 
Since `kwargs` is from the outer scope, adding to it will persist for
every time the deprecated wrapper function is called. Instead, save
the original `addendum` in the outer scope, and don't modify the outer
variables in the inner wrapper function.
@QuLogic QuLogic added this to the v3.3.0 milestone Jul 1, 2020
@QuLogic QuLogic requested a review from dopplershift July 1, 2020 06:52
anntzer
anntzer approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor
@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops.

@anntzer anntzer merged commit 5e11a23 into matplotlib:master Jul 1, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jul 1, 2020
@anntzer @meeseeksmachine
Backport PR matplotlib#17814: Don't duplicate deprecated parameter ad…
4827c58 
…dendum.
@meeseeksmachine meeseeksmachine mentioned this pull request Jul 1, 2020
Merged
dstansby added a commit that referenced this pull request Jul 1, 2020
@dstansby
Merge pull request #17815 from meeseeksmachine/auto-backport-of-pr-17…
c3ee86a 
…814-on-v3.3.x

Backport PR #17814 on branch v3.3.x (Don't duplicate deprecated parameter addendum.)
@QuLogic QuLogic deleted the deprecation-addendum branch July 1, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @dopplershift @anntzer
0