8000 Backport PR #14636 on branch v3.1.x: (Don't capture stderr in _check_and_log_subprocess.) by ivanov · Pull Request #14663 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Backport PR #14636 on branch v3.1.x: (Don't capture stderr in _check_and_log_subprocess.) #14663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2019
Merged

Backport PR #14636 on branch v3.1.x: (Don't capture stderr in _check_and_log_subprocess.) #14663

merged 2 commits into from
Jul 1, 2019

Conversation

ivanov
Copy link
Member
@ivanov ivanov commented Jun 30, 2019

manual backport of #14636: Don't capture stderr in _check_and_log_subprocess.

@ivanov
Copy link
Member Author
ivanov commented Jul 1, 2019

_pformat_subprocess is in master, but not in 3.1.x - so I decided to just simplify to use str, for the cases where the command is not a string. This makes any commands that were passed to _check_and_log_subprocess as a list of strings log as ["this", "was", "the", "command", "that", "ran"] instead of the nicer behavior on master, but it seemed like a reasonable trade off for not backporting more changes that were part of _pformat_subprocess related commits.

@ivanov ivanov merged commit b341b4e into matplotlib:v3.1.x Jul 1, 2019
@QuLogic QuLogic added this to the v3.1.1 milestone Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanov @QuLogic @anntzer
0