Don't capture stderr in _check_and_log_subprocess. #14636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Jun 27, 2019
lib/matplotlib/cbook/__init__.py
Outdated
| output (stdout and stderr); if not, raise an exception whose text includes | ||
| the failed command and captured output. Both the command and the output | ||
| are logged at DEBUG level on *logger*. | ||
| Run *command*. If it succeeds, return the its stdout output; if not, raise |
There was a problem hiding this comment.
s/the its/its/
but also docstrings should be split after the first sentence.
There was a problem hiding this comment.
thanks; reworded the docstring.
timhoffm
approved these changes
Jun 27, 2019
... to avoid capturing kpsewhich's "warning: running with administrator privileges" (that occurs at the only place where we actually care about the return value of _check_and_log_subprocess).
31e1d95 to
00b06da
Compare
ivanov
approved these changes
Jun 30, 2019
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
ivanov
pushed a commit
that referenced
this pull request
Jul 1, 2019
ivanov
added a commit
that referenced
this pull request
Jul 1, 2019
Backport PR #14636 on branch v3.1.x: (Don't capture stderr in _check_and_log_subprocess.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to avoid capturing kpsewhich's "warning: running with administrator
privileges" (that occurs at the only place where we actually care about
the return value of _check_and_log_subprocess).
Should close #14633 (I checked that the error does indeed get printed on stderr).
Not sure how this got to be a regression in 3.1.0, but milestoning as release critical as a consequence.
PR Summary
PR Checklist