8000 Fix bug in plot_directive that caused links to plots in different formats to be missing by astrofrog · Pull Request #14026 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix bug in plot_directive that caused links to plots in different formats to be missing #14026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2019
Merged

Fix bug in plot_directive that caused links to plots in different formats to be missing #14026

merged 1 commit into from
Apr 24, 2019

Conversation

astrofrog
Copy link
Contributor
@astrofrog astrofrog commented Apr 24, 2019 •
edited
Loading

PR Summary

441a6bc introduced some style changes that unfortunately also broke the display of available formats in the plot directive. I've reverted the relevant code to its original form.

Before this fix:

Screenshot 2019-04-24 at 10 58 08

After this fix:

Screenshot 2019-04-24 at 10 58 51

cc @anntzer as the author of 441a6bc

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@astrofrog astrofrog mentioned this pull request Apr 24, 2019
Closed
anntzer
anntzer approved these changes Apr 24, 2019
View reviewed changes
Copy link
Contributor
@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops :)

@anntzer anntzer added this to the v3.1.0 milestone Apr 24, 2019
@anntzer anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: sphinx extension labels Apr 24, 2019
@dstansby dstansby merged commit 4208a71 into matplotlib:master Apr 24, 2019
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 24, 2019
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 24, 2019
@dstansby
Backport PR matplotlib#14026: Fix bug in plot_directive that caused l…
c7c215f 
…inks to plots in different formats to be missing
dstansby added a commit that referenced this pull request Apr 24, 2019
@dstansby
Merge pull request #14027 from meeseeksmachine/auto-backport-of-pr-14…
89bb235 
…026-on-v3.1.x

Backport PR #14026 on branch v3.1.x (Fix bug in plot_directive that caused links to plots in different formats to be missing)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: sphinx extension
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@astrofrog @anntzer @dstansby
0