Merge pull request #14027 from meeseeksmachine/auto-backport-of-pr-14026-on-v3.1.x

dstansby · web-flow · commit 89bb235c97f5 · 2019-04-24T13:24:56.000+01:00
Backport PR #14026 on branch v3.1.x (Fix bug in plot_directive that caused links to plots in different formats to be missing)
diff --git a/lib/matplotlib/sphinxext/plot_directive.py b/lib/matplotlib/sphinxext/plot_directive.py
@@ -566,10 +566,14 @@ def render_figures(code, code_path, output_dir, output_base, context,
     # Look for single-figure output files first
     all_exists = True
     img = ImageFile(output_base, output_dir)
-    if not any(out_of_date(code_path, img.filename(fmt))
-               for fmt, dpi in formats):
+    for format, dpi in formats:
+        if out_of_date(code_path, img.filename(format)):
+            all_exists = False
+            break
+        img.formats.append(format)
+
+    if all_exists:
         return [(code, [img])]
-    img.formats.extend(fmt for fmt, dpi in formats)
 
     # Then look for multi-figure output files
     results = []
